-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new requirements to code generation of CMSE Entry function and Non-secure calls #319
Conversation
…n-secure calls This addresses the vulnerability described in CVE-2024-0151. Patch by Victor Campos. Co-authored-by: Victor Campos <[email protected]>
… and Non-secure calls - Reword requirement 47 and 58. - Replace "guidance" by "recommendation". - Rework example from requirement 47 to use a global array instead of one passed as argument.
bxns lr | ||
``` | ||
We recommend that function parameters with integral types smaller than 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for this recommendation? Are there other potential problems with small types, or is this because there are existing compilers which don't follow these rules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latter. There are a lot of older compilers out there that won't or can't be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This addresses the vulnerability described in CVE-2024-0151.
Patch by Victor Campos.
Co-authored-by: Victor Campos [email protected]