Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new requirements to code generation of CMSE Entry function and Non-secure calls #319

Merged
merged 2 commits into from
May 28, 2024

Conversation

pratlucas
Copy link
Contributor

This addresses the vulnerability described in CVE-2024-0151.

Patch by Victor Campos.

Co-authored-by: Victor Campos [email protected]

…n-secure calls

This addresses the vulnerability described in CVE-2024-0151.

Patch by Victor Campos.

Co-authored-by: Victor Campos <[email protected]>
cmse/cmse.md Outdated Show resolved Hide resolved
cmse/cmse.md Outdated Show resolved Hide resolved
cmse/cmse.md Outdated Show resolved Hide resolved
cmse/cmse.md Outdated Show resolved Hide resolved
… and Non-secure calls

- Reword requirement 47 and 58.
- Replace "guidance" by "recommendation".
- Rework example from requirement 47 to use a global array instead of
  one passed as argument.
bxns lr
```
We recommend that function parameters with integral types smaller than 4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for this recommendation? Are there other potential problems with small types, or is this because there are existing compilers which don't follow these rules?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter. There are a lot of older compilers out there that won't or can't be updated.

Copy link

@ostannard ostannard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vhscampos vhscampos merged commit 996abdb into ARM-software:main May 28, 2024
4 checks passed
Copy link
Contributor

@sallyarmneale sallyarmneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants