feat: added Keycloak support for email 2fa to #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleidig
reviewed
Oct 19, 2023
Member
sleidig
left a comment
sleidig
left a comment
There was a problem hiding this comment.
Code changes look very simple indeed.
How/where do we build this docker image? Let's add instructions in a readme file of the keycloak folder?
TheSlimvReal
force-pushed
the
email_2fa
branch
from
a819450 to
98659ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Keycloak to version 22 and added the SPIs:
Both are now included in the Keycloak image and can be configured for each realm.
openidas default scope (see openid scope is required for userinfo endpoint but does not exist by default keycloak/keycloak#16168)