Publish NE .dll #204
Publish NE .dll #204
Conversation
| <None Include="$(DnneGeneratedBinPath)/$(DnneNativeExportsBinaryName).pdb" Condition="$([MSBuild]::IsOsPlatform('Windows'))"> | ||
| <PublishState>Included</PublishState> | ||
| </Content> | ||
| <None Include="$(DnneGeneratedBinPath)/$(DnneNativeExportsBinaryName).pdb" Condition="$([MSBuild]::IsOsPlatform('Windows')) AND '$(DnneBuildExports)' == 'true'"> |
There was a problem hiding this comment.
This condition is on the enclosing ItemGroup, is it also needed here?
There was a problem hiding this comment.
Not needed here, I just missed the condition on the ItemGroup.
What exactly are the semantics of DnneBuildNativeExports vs DnneGenerateExports vs DnneAddGeneratedBinaryToProject? I'd imagine the .c and .h files still be copied if DnneBuildNativeExports != true but DnneGenerateExport == true, but with the condition on the ItemGroup it looks like they won't be copied to the output folder.
There was a problem hiding this comment.
DnneGenerateExports - Toggles if the .h and .c files should be generated based on the .NET assembly. It fails if there aren't any exports.
DnneBuildNativeExports - Toggles if the native binary with the exports are compiled.
DnneAddGeneratedBinaryToProject - Toggles if the native binary should flow with the project references.
|
I misunderstood the flags and assumed something was wrong, but I just need to add DnneAddGeneratedBinaryToProject. |
The native exports library doesn't get copied to the publish folder by default, so this adds it to an itemgroup to do that.
Should the .c, .h, and .lib folders also be published?