fix(Feature flags): use response.results when showing feature flags i…

…n an infinite list (PostHog#26099) Use response.results, if the groupType is feature flags, since the response value changed recently.
Aashw1n · Nov 8, 2024 · e28af15 · e28af15
1 parent 7cfd244
commit e28af15
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/frontend/src/lib/components/TaxonomicFilter/infiniteListLogic.ts b/frontend/src/lib/components/TaxonomicFilter/infiniteListLogic.ts
@@ -246,7 +246,10 @@ export const infiniteListLogic = kea<infiniteListLogicType>([
                     const group = taxonomicGroups.find((g) => g.type === props.listGroupType)
 
                     if (group?.logic && group?.value) {
-                        const items = group.logic.selectors[group.value]?.(state)
+                        let items = group.logic.selectors[group.value]?.(state)
+                        if (group?.value === 'featureFlags' && items.results) {
+                            items = items.results
+                        }
                         // TRICKY: Feature flags don't support dynamic behavioral cohorts,
                         // so we don't want to show them as selectable options in the taxonomic filter
                         // in the feature flag UI.
@@ -255,6 +258,7 @@ export const infiniteListLogic = kea<infiniteListLogicType>([
                         if (Array.isArray(items) && items.every((item) => 'filters' in item)) {
                             return filterOutBehavioralCohorts(items, props.hideBehavioralCohorts)
                         }
+
                         return items
                     }
                     if (group?.options) {

diff --git a/posthog/api/web_experiment.py b/posthog/api/web_experiment.py
@@ -186,7 +186,10 @@ def web_experiments(request: Request):
             )
 
         result = WebExperimentsAPISerializer(
-            WebExperiment.objects.filter(team_id=team.id).exclude(archived=True).select_related("feature_flag"),
+            WebExperiment.objects.filter(team_id=team.id)
+            .exclude(archived=True)
+            .exclude("end_date__isnull", False)
+            .select_related("feature_flag"),
             many=True,
         ).data