-
Notifications
You must be signed in to change notification settings - Fork 7
[1.21] Include actual y level for anchor tooltips #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
based on the client's current dimension Signed-off-by: unilock <[email protected]>
Hm, it is a little busy, perhaps the relative values could be switched out for absolute (for the current dimension) when the shift key is held? This could also apply to the values on the "graph". Also, the default could be configurable in the config file. Sorry for continuing to request changes on this PR, after this many months one is bound to have new ideas of how best to implement things :P As for the 1.20.1 port, I've moved to a new merge-down workflow (inspired by EMI's) so any changes will naturally get propagated down to the backports (including 1.19.2). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refer to comment
Signed-off-by: unilock <[email protected]>
I've implemented showing the height values for the current dimension only when shift is held - however, it appears that it's necessary to manually refresh the recipe's display while holding shift (e.g. by switching recipe pages in EMI) to get the values to update. I am not sure how to fix this :p |
Signed-off-by: unilock <[email protected]>
The config has been implemented as well. I suppose the distribution graph tooltip should also be updated to indicate that holding shift will change which height values are displayed, but the tooltip is quite long already... |
Signed-off-by: unilock <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you! |
This PR adds the actual y level to the "distribution" tooltips that lack it, based on the client's current dimension. As discussed in #16, a note is also added to relative tooltips that the values only apply to the current dimension.
Maybe the note should also mention that the current dimension may not contain every feature? It feels a little long already...
Examples:
( Hopefully this can be cherry-picked to 1.20.1 as well? :p )