Skip to content

[1.21] Include actual y level for anchor tooltips #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

unilock
Copy link
Contributor

@unilock unilock commented Feb 1, 2025

This PR adds the actual y level to the "distribution" tooltips that lack it, based on the client's current dimension. As discussed in #16, a note is also added to relative tooltips that the values only apply to the current dimension.

Maybe the note should also mention that the current dimension may not contain every feature? It feels a little long already...

Examples:

Screenshot 2025-02-01 at 7 47 00 AM Screenshot 2025-02-01 at 7 47 06 AM

( Hopefully this can be cherry-picked to 1.20.1 as well? :p )

based on the client's current dimension

Signed-off-by: unilock <[email protected]>
@Abbie5
Copy link
Owner

Abbie5 commented Feb 1, 2025

Hm, it is a little busy, perhaps the relative values could be switched out for absolute (for the current dimension) when the shift key is held? This could also apply to the values on the "graph". Also, the default could be configurable in the config file.

Sorry for continuing to request changes on this PR, after this many months one is bound to have new ideas of how best to implement things :P

As for the 1.20.1 port, I've moved to a new merge-down workflow (inspired by EMI's) so any changes will naturally get propagated down to the backports (including 1.19.2).

Copy link
Owner

@Abbie5 Abbie5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refer to comment

@unilock
Copy link
Contributor Author

unilock commented Feb 4, 2025

I've implemented showing the height values for the current dimension only when shift is held - however, it appears that it's necessary to manually refresh the recipe's display while holding shift (e.g. by switching recipe pages in EMI) to get the values to update. I am not sure how to fix this :p

@unilock
Copy link
Contributor Author

unilock commented Feb 4, 2025

The config has been implemented as well. I suppose the distribution graph tooltip should also be updated to indicate that holding shift will change which height values are displayed, but the tooltip is quite long already...

Copy link
Owner

@Abbie5 Abbie5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Abbie5 Abbie5 merged commit 8bda8e5 into Abbie5:1.21 Feb 4, 2025
1 check passed
@Abbie5
Copy link
Owner

Abbie5 commented Feb 4, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants