Skip to content

Conversation

Idclip
Copy link
Contributor

@Idclip Idclip commented Dec 6, 2023

Re-creating this so that we don't lose visibility on it. It currently cannot be merged due to #1700

… remaining mandatory boost dependency

Signed-off-by: Nick Avramoussis <[email protected]>
@Idclip Idclip force-pushed the remove_boost_promote branch from 69df857 to 480d864 Compare December 6, 2023 03:33
@Idclip Idclip marked this pull request as draft December 12, 2023 20:48
@bpmckinnon
Copy link
Contributor

One possible option given that std::numeric_limits is overridden is to try using std::numeric_limits::is_specialized instead.
https://en.cppreference.com/w/cpp/types/numeric_limits/is_specialized

@bpmckinnon
Copy link
Contributor

I've verified that this is at least a potential option on my windows build... but I can't guarantee it will work in the build environment that is failing.

@apradhana
Copy link
Contributor

As for the problem that Matthew raised in Issue 1700 , I have a fix that I included in the draft PR for supporting half grid. What's needed is adding a cwiseAdd specialization for Vec3<math::half> as shown here.

@bpmckinnon
Copy link
Contributor

Has there been any update on the cwiseAdd function? Otherwise I can add the is_specialized change I proposed.

@bpmckinnon
Copy link
Contributor

Before this change can be resubmitted std::is_arithmetic_v should be replaced with std::numeric_limits::is_specialized to prevent the initial issue that was flagged

@danrbailey danrbailey changed the base branch from master to feature/boost_numeric September 18, 2024 04:42
@danrbailey danrbailey marked this pull request as ready for review September 18, 2024 04:43
@danrbailey
Copy link
Contributor

Merging to a feature branch to bring this PR up-to-date before merging to master.

@danrbailey danrbailey merged commit 659ef6d into AcademySoftwareFoundation:feature/boost_numeric Sep 18, 2024
41 checks passed
@Idclip Idclip deleted the remove_boost_promote branch July 28, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants