Fix a memory-leak in RootNode::deleteChildOrTile() #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r warning Signed-off-by: Dan Bailey <[email protected]>
jmlait
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
I see.... the RootNode::NodeStruct::set method will delete the existing child, which means the clip methods:
setTile(this->findCoord(xyz), bgTile); // delete any existing child node first
mTable.erase(xyz);
would be implicitly deleting the child in the setTile method.
danrbailey
merged commit 8a81dbb
into
AcademySoftwareFoundation:master
40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The address sanitizer CI picked up that there was a memory leak in the
RootNode::deleteChildOrTile()method and I realize that the NodeStruct doesn't delete the child on destruction so I've fixed this by explicitly deleting it.I also added a warning that this method will invalidate existing iterators as previously requested.
(@kmuseth)