Don't die on "pong" response #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we ping_hb() the server pongs. If you sleep long enough for this to happen (152 seconds?) your subsequent operations fail, ultimately due to trying to parse `pong` as JSON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce, make a script that:
ping_hb()has run at least once (> 152 seconds for me)It fails with some combination of
TimeoutErrorandCancelledError, and after I Ctrl-c the script I see a JSON parse error at character 0 happening on the line in the patch below.With this patch, my long-lived script is happy - specifically I'm watching the Hue event stream for button-presses with aiohue
bridge.subscribe(handler).