Conversation
Member
|
Is a Rails engine overkill for this? I'm wondering whether this couldn't just be a Rack app with a route pointing to it? |
6767db5 to
9e549b5
Compare
Also switch testing from Circle to Travis-CI
Contributor
|
I'll try this pull request out by tomorrow. @no-reply - No experience with a Rack app. What makes the engine overkill exactly? |
| uri_endpoint: 'http://localhost:3000/{?subject}' | ||
| uri_root: 'http://localhost:3000/#dataset' | ||
| cache_backend: | ||
| provider: 'marmotta' |
Contributor
There was a problem hiding this comment.
It seems like we are only copying over one config file now. If this is the case, why not have it be the Repository one as it requires no additional running software? We can then provide documentation or samples on how to configure it against a Marmotta, Blazegraph, etc. instance.
Contributor
|
Some other quick notes beyond the comments above from some testing:
Seems to work otherwise but will test it some more tonight. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.