-
-
Notifications
You must be signed in to change notification settings - Fork 69
fix: changes BTS transaction status on rejected in chat when node validation fails #857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
2b6a1f8
8fa4885
15da562
273bd60
496489d
1f92232
1efdacf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -231,7 +231,15 @@ function createActions(options) { | |
|
|
||
| return hash | ||
| } catch (error) { | ||
| if (error.response && error.response.data) { | ||
Linhead marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| if ( | ||
| ((crypto === 'BTC' || crypto === 'DOGE') && error.response.data.includes('dust')) || | ||
| (crypto === 'DASH' && error.response.data.error.message.includes('dust')) | ||
| ) | ||
| context.commit('dustedTransactionsIds', signedTransaction.txid) | ||
| } | ||
| context.commit('transactions', [{ hash: signedTransaction.txid, status: 'REJECTED' }]) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. May be it's better not to use
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was my first idea. But I paid attention that transactions from store show only on wallet page. On chat page list of transactions are fetching by API call. That's why I need to check each transaction from API response if it was rejected by dust amount.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see, thanks.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Do we still store transaction info locally?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @adamantmm I've created a new PR for this fix - #866 |
||
|
|
||
| PendingTxStore.remove(context.state.crypto) | ||
| throw error | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dustedIds.length > 0is excessive