fix: correct scroll position when closing keyboard on mobile #887
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed incorrect scroll position adjustment in chat when closing mobile keyboard. The
resizeHandlerinAChat.vuewas applying scroll correction regardless of viewport resize direction, causing the chat to scroll up ~4-5 messages when keyboard closes.Changes:
clientHeightDelta > 0to only adjust scroll when viewport shrinks (keyboard opens)Related issue
Closes #886
Breaking changes
No
How to test
Prerequisites
Test Steps
Test Case 1: Basic keyboard close
Expected: Last sent message ("test 5") is visible at bottom
Actual before fix: Last message is hidden, need to scroll down manually
Test Case 2: Scrolling with keyboard open
Expected: Scroll position preserved at the same messages
Actual before fix: Scroll jumps up further, hiding more messages
Test Case 3: Rapid message sending
Expected: Last message visible
Actual before fix: Last ~4 messages hidden
Notes for reviewers
Highlight anything important that reviewers should pay attention to.
(e.g. tricky logic, potential side effects, performance considerations)
Checklist