Skip to content

fix: correct amount calculation for self-transfer transactions in BTC… #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

fix: correct amount calculation for self-transfer transactions in BTC… #890

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
948eb9a
fix: correct amount calculation for self-transfer transactions in BTC…
Linhead Oct 7, 2025
b628ae2
feat: add color coding for transaction direction icons
Linhead Oct 10, 2025
1a123ad
fix: correct amount calculation for self-transfer transactions in BTC…
Linhead Oct 13, 2025
ed7f4bd
fix: fix recepient address and transaction status for transactions wi…
Linhead Oct 14, 2025
c53ee3a
test: add unit tests for BTC, DASH, and DOGE transaction normalization
Linhead Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/lib/nodes/btc-indexer/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export function normalizeTransaction(
const recipients = tx.vout.map((vout) => vout.scriptpubkey_address)

const direction = senders.includes(ownerAddress) ? 'from' : 'to'
const isSelfTransfer = senders.includes(ownerAddress) && recipients.includes(ownerAddress)

if (direction === 'from') {
// Disregard our address for an outgoing transaction unless it's the only address (i.e. we're sending to ourselves)
Expand All @@ -31,9 +32,10 @@ export function normalizeTransaction(
// Calculate amount from outputs:
// * for the outgoing transactions take outputs that DO NOT target us
// * for the incoming transactions take outputs that DO target us
// * for self-transfers take outputs that DO target us
const amount = tx.vout.reduce(
(sum, t) =>
(direction === 'to') === (t.scriptpubkey_address === ownerAddress)
(isSelfTransfer || direction === 'to') === (t.scriptpubkey_address === ownerAddress)
? sum + Number(t.value)
: sum,
0
Expand Down
4 changes: 3 additions & 1 deletion src/lib/nodes/dash/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export function normalizeTransaction(tx: Transaction, ownerAddress: string): Das
const recipients = tx.vout.flatMap((vout) => vout.scriptPubKey.addresses).filter(onlyUnique)

const direction = senders.includes(ownerAddress) ? 'from' : 'to'
const isSelfTransfer = senders.includes(ownerAddress) && recipients.includes(ownerAddress)

if (direction === 'from') {
// Disregard our address for an outgoing transaction unless it's the only address (i.e. we're sending to ourselves)
Expand All @@ -29,9 +30,10 @@ export function normalizeTransaction(tx: Transaction, ownerAddress: string): Das
// Calculate amount from outputs:
// * for the outgoing transactions take outputs that DO NOT target us
// * for the incoming transactions take outputs that DO target us
// * for self-transfers take outputs that DO target us
const amount = tx.vout.reduce(
(sum, t) =>
(direction === 'to') === t.scriptPubKey.addresses.includes(ownerAddress)
(isSelfTransfer || direction === 'to') === t.scriptPubKey.addresses.includes(ownerAddress)
? sum + Number(t.value)
: sum,
0
Expand Down
4 changes: 3 additions & 1 deletion src/lib/nodes/doge-indexer/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export function normalizeTransaction(tx: Transaction, ownerAddress: string): Dog
const recipients = tx.vout.flatMap((vout) => vout.scriptPubKey.addresses).filter(onlyUnique)

const direction = senders.includes(ownerAddress) ? 'from' : 'to'
const isSelfTransfer = senders.includes(ownerAddress) && recipients.includes(ownerAddress)

if (direction === 'from') {
// Disregard our address for an outgoing transaction unless it's the only address (i.e. we're sending to ourselves)
Expand All @@ -31,9 +32,10 @@ export function normalizeTransaction(tx: Transaction, ownerAddress: string): Dog
// Calculate amount from outputs:
// * for the outgoing transactions take outputs that DO NOT target us
// * for the incoming transactions take outputs that DO target us
// * for self-transfers take outputs that DO target us
const amount = tx.vout.reduce(
(sum, t) =>
(direction === 'to') === t.scriptPubKey.addresses.includes(ownerAddress)
(isSelfTransfer || direction === 'to') === t.scriptPubKey.addresses.includes(ownerAddress)
? sum + Number(t.value)
: sum,
0
Expand Down