Skip to content

Commit

Permalink
Merge pull request #120 from AddSearch/sc-10289/fix-bug-in-calculate-…
Browse files Browse the repository at this point in the history
…slider-ranges

[sc-10289] rounding the min-max value of input type=range
  • Loading branch information
haoAddsearch authored Jul 19, 2024
2 parents 7f5a3fc + f39b50d commit 0310a2f
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 6 deletions.
2 changes: 1 addition & 1 deletion dist/addsearch-search-ui.min.css

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/addsearch-search-ui.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "addsearch-search-ui",
"version": "0.8.9",
"version": "0.8.10",
"description": "JavaScript library to develop Search UIs for the web",
"main": "./dist/addsearch-search-ui.min.js",
"jsdelivr": "./dist/addsearch-search-ui.min.js",
Expand Down
6 changes: 6 additions & 0 deletions src/components/activefilters/activefilters.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,13 @@ export default class ActiveFilters {

// Range facets
for (let field in filterState.activeRangeFacets) {
if (!filterState.activeRangeFacets.hasOwnProperty(field)) {
continue;
}
for (let key in filterState.activeRangeFacets[field]) {
if (!filterState.activeRangeFacets[field].hasOwnProperty(key)) {
continue;
}
active.push({
name: field,
type: TYPE.RANGE_FACET,
Expand Down
4 changes: 3 additions & 1 deletion src/components/rangefacets/rangefacets.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,9 @@ export default class RangeFacets {
this.reduxStore.dispatch(setFieldStats(res.fieldStats, this.conf.field));
});
} else {
this.reduxStore.dispatch(setFieldStats(search.results.fieldStats, this.conf.field));
this.renderRangeSlider({
fieldStats: search.results.fieldStats
})
}

});
Expand Down
4 changes: 3 additions & 1 deletion src/util/sliders.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ function UiRangeSlider() {
sliderId = containerId;

const [min, max, start, end] = getSliderValue();
initVisuals([min, max, start, end], settings.step);
const maxRounded = Math.ceil(parseFloat(max));
const minRounded = Math.floor(parseFloat(min));
initVisuals([minRounded, maxRounded, start, end], settings.step);

const rangeStyles = settings.styles;
const fromSlider = document.querySelector('#' + containerId + ' [data-id=adds-slider-control-from]');
Expand Down

0 comments on commit 0310a2f

Please sign in to comment.