Skip to content

Fix intel.com #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

Fix intel.com #1096

merged 1 commit into from
Jun 20, 2025

Conversation

AdamWr
Copy link
Member

@AdamWr AdamWr commented Jun 20, 2025

Fix AdguardTeam/AdguardFilters#207905

Fixes problem with downloading files on intel.com.

File cannot be downloaded when dogo.intel.com is blocked (it comes from https://github.com/AdguardTeam/cname-trackers/blob/master/data/trackers/adobe-experience-cloud-(formerly-omniture).txt).

Fix AdguardTeam/AdguardFilters#207905 intel.com

Fixes problem with downloading files.

File cannot be downloaded when `dogo.intel.com` is blocked (it comes from https://github.com/AdguardTeam/cname-trackers/blob/master/data/trackers/adobe-experience-cloud-(formerly-omniture).txt).
@AdamWr AdamWr requested a review from a team June 20, 2025 11:58
Copy link

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤙

💡 To request another review, post a new comment with "/windsurf-review".

@Alex-302
Copy link
Member

Should not it be unblocked in DNS filter?
Like here https://github.com/AdguardTeam/AdGuardSDNSFilter/pull/1912/files

@Alex-302
Copy link
Member

CC: @hagezi I see same rule in your filters. Are users not complaining?

@AdamWr
Copy link
Member Author

AdamWr commented Jun 20, 2025

Should not it be unblocked in DNS filter? Like here https://github.com/AdguardTeam/AdGuardSDNSFilter/pull/1912/files

It's also blocked in AdGuard Tracking Protection filter without DNS filtering enabled, so I thought that it's correct place to fix it.
But perhaps it should be unblocked in two places?

@hagezi
Copy link

hagezi commented Jun 20, 2025

@Alex-302 So far there have been no issues, I'll have a look.

@Alex-302
Copy link
Member

But perhaps it should be unblocked in two places?

Hm. Let's check if it disappears in the DNS filter after next compile of FiltersRegistry.

@AdamWr AdamWr merged commit 00cd8c8 into master Jun 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

www.intel.com
5 participants