Skip to content
This repository was archived by the owner on Jan 6, 2022. It is now read-only.

Tag implementation #302

Open
DaDevChia wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Tag implementation #302

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
e27d5c1
Implemented initial version
DaDevChia Aug 22, 2021
0992af9
removed unecessary elements
DaDevChia Aug 22, 2021
47e7588
removed underline
DaDevChia Aug 22, 2021
9184a02
changes
DaDevChia Aug 23, 2021
65ea518
page-stories.hbs: Implement "Load More" button (#274)
wei2912 Aug 28, 2021
433df46
fixes applied
DaDevChia Aug 28, 2021
049ff01
Interim
DaDevChia Aug 28, 2021
cebfe5c
updated implementation
DaDevChia Aug 29, 2021
50a96a9
reverted border to 2
DaDevChia Aug 29, 2021
d2684c3
final implementation
DaDevChia Aug 29, 2021
c7c675c
build(deps): bump gulp-postcss from 9.0.0 to 9.0.1
dependabot[bot] Aug 30, 2021
4f8742d
removed underline and added shadow
DaDevChia Sep 10, 2021
ec37f62
Use Alpine JS for Templating Event Cards (#306)
Hackin7 Sep 11, 2021
27704b8
Implemented initial version
DaDevChia Aug 22, 2021
83ec775
removed unecessary elements
DaDevChia Aug 22, 2021
8f03403
removed underline
DaDevChia Aug 22, 2021
1a17733
changes
DaDevChia Aug 23, 2021
fb7b4ec
fixes applied
DaDevChia Aug 28, 2021
9973823
Interim
DaDevChia Aug 28, 2021
99be361
updated implementation
DaDevChia Aug 29, 2021
23b1585
reverted border to 2
DaDevChia Aug 29, 2021
a1e9e08
final implementation
DaDevChia Aug 29, 2021
eaba593
removed underline and added shadow
DaDevChia Sep 10, 2021
7d82d08
Merge branch 'pill-tag-implementation' of https://github.com/Advisory…
DaDevChia Sep 14, 2021
65e4130
Changes
DaDevChia Sep 14, 2021
d5ed851
Squash and Rebase from Master (#310)
DaDevChia Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions post.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,6 @@
<time datetime="{{date format="YYYY-MM-DD"}}">
{{date format="D MMM YYYY"}}
</time>
<span>
Tags:&nbsp;
{{#foreach tags}}
<span class="gh-post-meta-content-item">
<a href={{url}}>
{{name}}
</a>
</span>
{{/foreach}}
</span>
<span>
Written by:&nbsp;
{{#foreach authors}}
Expand All @@ -31,6 +21,19 @@
</span>
{{/foreach}}
</span>
<span>
{{reading_time}}
</span>
</span>

<span class="flex flex-wrap content-center gap-4 justify-center">
{{#foreach tags}}
<div class="flex-none text-base text-black hover:underline border-2 border-black hover:border-yellow-500 rounded-full px-3">
Copy link
Member

@wei2912 wei2912 Sep 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good if, on hover, the background darkens slightly. See https://material-ui.com/components/chips/ for an example.

Copy link
Contributor Author

@DaDevChia DaDevChia Sep 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

<a href={{url}}>
Copy link
Member

@wei2912 wei2912 Sep 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, I think having underline for this doesn't fit well... could you add a class to disable the underline on hover?

Copy link
Member

@wei2912 wei2912 Sep 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can the text here be of the same colour as the span above?

Copy link
Contributor Author

@DaDevChia DaDevChia Sep 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"same colour as the span above?"

Im not sure which element youre referring to. It could be:

  1. Light grey "Written By:" color
  2. Black Title color (no difference)

Copy link
Member

@wei2912 wei2912 Sep 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm referring to the light grey color. Apologies for the ambiguity!

Copy link
Contributor Author

@DaDevChia DaDevChia Sep 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

{{name}}
</a>
</div>
{{/foreach}}
</span>

{{#if custom_excerpt}}
Expand Down
12 changes: 11 additions & 1 deletion tailwind.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,17 @@ module.exports = {
],
darkMode: false, // or 'media' or 'class'
theme: {
extend: {},
extend: {
typography: {
DEFAULT: {
css: {
a: {
textDecoration: "none",
Copy link
Member

@wei2912 wei2912 Aug 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a big fan of this as it leaves users with no visual indication of hyperlinks, and makes life difficult if we don't use other colours to distinguish.

Copy link
Member

@wei2912 wei2912 Sep 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revert the changes in tailwind.config.js? Thanks!

Copy link
Member

@wei2912 wei2912 Sep 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll assign @Hackin7 to work on this too, since it is related to #309.

},
},
},
},
},
},
variants: {
extend: {},
Expand Down