Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPT-81] Home: Redesign testimonial to show Mentee/Mentor side-by-side #735

Open
wei2912 opened this issue Mar 5, 2024 · 14 comments
Open
Assignees
Labels
Design Created by Linear-GitHub Sync Feature Created by Linear-GitHub Sync

Comments

@wei2912
Copy link
Member

wei2912 commented Mar 5, 2024

Currently, we have a single column with a tag saying Mentor/Mentee:

image

Since we plan to feature a mentee/mentor side-by-side, there should be two columns with the carousel controlling both.

Before starting on code, a design mockup should be created first.

From SyncLinear.com | MPT-81

@wei2912 wei2912 added Feature Created by Linear-GitHub Sync Design Created by Linear-GitHub Sync labels Mar 5, 2024
@wei2912
Copy link
Member Author

wei2912 commented Mar 17, 2024

Assigned to @jcc-kh for design ideation.

@w3joe
Copy link
Contributor

w3joe commented Apr 13, 2024

@jcc-kh, I have created a design mockup for the mobile version of the carousell, do let me know what you think:

image

@jcc-kh
Copy link

jcc-kh commented May 1, 2024

Now that I look at it, looks a bit weird that the photos are not entirely in the box, would it be possible if both the mobile and laptop versions of photos have the photos in the box and aligned with the paragraph (meaning the name, organisation & title) also shift inwards, photo is outermost but still aligned with paragraph)

@w3joe
Copy link
Contributor

w3joe commented May 1, 2024

Sure, something like this? For the mobile the paragraph (Name, org, title) is a bit of a squeeze but I can try coding it out first and see how it looks.

image

@wei2912
Copy link
Member Author

wei2912 commented May 11, 2024

Some comments:

  1. Mentee vs mentor distinction is not so clear - easy way is to just make the pill tags with "Mentor" or "Mentee" bigger, other ways might be having distinct background colours, using icons?
  2. Left/right buttons would be more intuitive if placed at the sides on desktop, rather than at the bottom.

That said, I think the current design is already good enough for MVP - in the interest of time (since we ought to finish preparing the website by end of this month), could we get this implemented first?

@jcc-kh
Copy link

jcc-kh commented Jun 30, 2024

@wei2912 I'm wondering if it would be better for name, organisation and title to be in the same line

@wei2912
Copy link
Member Author

wei2912 commented Nov 30, 2024

@ykIsCoding I'll reach out to @w3joe to get the code for the PR, can just look through the design and code, then discuss with me and @jcc-kh on how to proceed.

@wei2912
Copy link
Member Author

wei2912 commented Dec 8, 2024

https://flowbite.com/docs/components/carousel/ might be useful

we aren't currently using Flowbite but I'm okay to import it (see https://flowbite.com/docs/getting-started/quickstart/)

@ykIsCoding
Copy link
Contributor

Hi @wei2912 @jcc-kh I have requested to edit the figma. Will show the mockup prior to coding the thing out

@ykIsCoding
Copy link
Contributor

image

changed the UI to this to better differentiate mentor and mentee.

For mobile screen i have increased the button size for easier navigation.

btw i still cant edit the figma, i just copied onto my own figma file to edit.

@wei2912
Copy link
Member Author

wei2912 commented Dec 11, 2024

@ykIsCoding could you include your Figma link? thanks!

@jcc-kh for your review :P

@ykIsCoding
Copy link
Contributor

@wei2912 wei2912 changed the title [MPT-81] Home: Split Mentee/Mentor testimonials into side-by-side [MPT-81] Home: Redesign testimonial to show Mentee/Mentor side-by-side Dec 30, 2024
@wei2912
Copy link
Member Author

wei2912 commented Jan 4, 2025

@jcc-kh to get back to @ykIsCoding on the design soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Created by Linear-GitHub Sync Feature Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

5 participants