Skip to content

[MPT-66] Home: Carousel arrows are flipped on narrow displays #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2024

Conversation

Unknownflow
Copy link
Contributor

I modified the margin-left and margin-right of the arrows such that they make use of a percentage value for the margin instead of a fix value of 0 and 300px. This prevents the carousel arrows to be flipped on narrow displays.

@Unknownflow Unknownflow self-assigned this Mar 4, 2024
Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for tender-meitner-99286b ready!

Name Link
🔨 Latest commit 67210b2
🔍 Latest deploy log https://app.netlify.com/sites/tender-meitner-99286b/deploys/65eda7e91eb9c900077312f6
😎 Deploy Preview https://deploy-preview-732--tender-meitner-99286b.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Unknownflow Unknownflow linked an issue Mar 4, 2024 that may be closed by this pull request
@Unknownflow Unknownflow requested review from a team and wei2912 and removed request for a team March 4, 2024 06:47
Copy link
Member

@wei2912 wei2912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the bug, but distance between arrows is quite small on narrower devices. Could this be updated? Arrows positioned around 25% and 75% of width might work.

image

Copy link
Member

@wei2912 wei2912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tho I think we will be making more significant changes in #735.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MPT-66] Home: Carousel arrows are flipped on narrow displays
2 participants