-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPT-44] Change search result highlighting #653
Conversation
✅ Deploy Preview for tender-meitner-99286b ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Think the highlighting should be of similar style to this: Rather than simply applying bold or italics, which doesn't really stand out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment. Note that your solution should avoid replacing the em
tags with strong
since em
is meant to semantically represent emphasis (which can be styled in different ways, e.g. bold/italics/underline/highlighting) rather than styling the text specifically to be bold.
I have changed the highlighting of the search result to be of similar style to the image provided in #644. |
This reverts commit a2a24b3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a few more questions about the code, otherwise LGTM.
I have changed the search result highlighting from italics to bold.