Skip to content

Copy payment method data to clipboard #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Conversation

OscarSpruit
Copy link
Collaborator

@OscarSpruit OscarSpruit commented Nov 5, 2024

Description

  • Add the ability to copy payment method data to the clipboard
  • Update dependencies

COAND-1030

Screenshot_20241105_192849

Release notes

New

  • Added the ability to copy payment method data to the clipboard

Fixed

  • Fixed something
  • Fixed something else

Here is another header

Some content

@OscarSpruit OscarSpruit requested a review from a team as a code owner November 5, 2024 18:30
import com.adyen.testcards.R

@Composable
fun CopyMenu(
Copy link

@araratthehero araratthehero Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of using the copy icon next to each item, instead of creating a header?

image
Got the image from here.

Copy link
Collaborator Author

@OscarSpruit OscarSpruit Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had that before, but the icon is very repetitive and so is prefixing every item with "Copy ${title of your item}". I figured doing it once in a title makes it look less noisy

Copy link

@araratthehero araratthehero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link

sonarqubecloud bot commented Nov 7, 2024

@OscarSpruit OscarSpruit merged commit 81a0ba3 into main Nov 7, 2024
4 checks passed
@OscarSpruit OscarSpruit deleted the feature/copy-paste branch November 7, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants