-
Notifications
You must be signed in to change notification settings - Fork 165
Add IRIS payment component #3708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: a4d518d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for adyen-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @johnayeni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces a new Iris payment component, including its Storybook configuration and integration into the existing component structure. The changes involve adding new files for the Iris component, updating the TxVariants enum, and exporting the new component. A significant change was made to the IssuerListContainer.tsx file, specifically to the isValid getter, which now unconditionally returns true. This change needs careful consideration as it bypasses the intended validation logic for components extending IssuerListContainer.
packages/lib/src/components/helpers/IssuerListContainer/IssuerListContainer.tsx
Show resolved
Hide resolved
size-limit report 📦
|
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the new Iris payment component, which is a significant and well-executed addition. The implementation is robust, featuring two distinct modes (Bank List and QR Code) with a responsive default based on the device type. The changes are thoroughly supported by a comprehensive suite of Storybook stories, unit tests, and end-to-end accessibility tests, which is excellent. I also appreciate the thoughtful refactoring of existing components like IssuerListContainer and the creation of the reusable SegmentedControlRegion to improve type safety and accessibility. My feedback includes a minor suggestion to improve module organization for cleaner imports.
0990430 to
97917a6
Compare
packages/lib/src/components/Iris/components/IrisComponent.module.scss
Outdated
Show resolved
Hide resolved
packages/lib/src/components/internal/SegmentedControl/SegmentedControlRegion.tsx
Show resolved
Hide resolved
46925ea to
c501d14
Compare
…d validate contract before fowarding to the component
This reverts commit bc0692e.
340d74c to
eebccc4
Compare
|



📋 Pull Request Checklist
📝 Summary
IRIS Payment is a real-time bank transfer system, popular in Greece, allowing direct payments from a customer's bank account via their mobile banking app, often by scanning a QR code or by selecting an bank issuer to be redirected to. This PR adds proper support for this Payment method to the SDK.
🧪 Tested scenarios
Both the redirect flow and the qr code flow for the IRIS payment method have been covered by the following tests
🔗 Related GitHub Issue / Internal Ticket number
COSDK-861
Closes: