Skip to content

Conversation

@johnayeni
Copy link
Contributor

@johnayeni johnayeni commented Jan 6, 2026

📋 Pull Request Checklist

  • I have added unit tests to cover my changes.
  • I have added or updated Storybook stories where applicable.
  • I have tested the changes manually in the local environment.
  • I have checked that no PII data is being sent on analytics events
  • All E2E tests are passing, and I have added new tests if necessary.
  • All interfaces and types introduced or updated are strictly typed.

📝 Summary

This PR adds support for the alternativeReference field to the Econtext voucher result. Econtext supports 5 tx variants and the econtext_atm variant now supports an alternativeReference field. If this field is present in the payment action for the component, the voucher result is displayed differently.

Screenshot 2026-01-06 at 16 59 55

🧪 Tested scenarios


🔗 Related GitHub Issue / Internal Ticket number

COSDK-772

Closes:


@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2026

🦋 Changeset detected

Latest commit: 3a14d3c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adyen/adyen-web Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 6, 2026

Deploy Preview for adyen-web ready!

Name Link
🔨 Latest commit 3a14d3c
🔍 Latest deploy log https://app.netlify.com/projects/adyen-web/deploys/6966249ce7f2ba000841d2ef
😎 Deploy Preview https://deploy-preview-3749.checkout-web-dev.adyen.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @johnayeni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on extending the functionality and improving the robustness of the Econtext payment method integration. It introduces the capability to handle an alternativeReference for Econtext ATM vouchers, which intelligently modifies the voucher display to provide clearer information to the user. Additionally, the PR enhances the development experience by adding comprehensive Storybook examples for various Econtext payment types and refactoring internal component reference mechanisms for better maintainability and testability.

Highlights

  • Enhanced Econtext Voucher Display: Introduced support for an alternativeReference in Econtext vouchers, dynamically adjusting the displayed details, copy button visibility, and reference value based on its presence.
  • Expanded Econtext Storybook Coverage: Added new Storybook stories for EcontextATM, EcontextOnline, and EcontextStores to improve component testing and documentation.
  • Refactored Component Reference Handling: Improved the management of component references (setComponentRef) and validation (showValidation) within EcontextInput and PersonalDetails components using useEffect hooks.
  • Updated Preact Devtools Configuration: Enabled Preact devtools in production builds within the Storybook configuration for better debugging capabilities.
  • Refined Type Definitions: Updated Econtext and Voucher related type interfaces to include new properties like alternativeReference and to explicitly define Intl.DateTimeFormatOptions for date formatting.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for an alternative reference for econtext_atm payments, which changes the information displayed on the voucher. It also includes significant refactoring across several components to improve type safety and adopt modern React hook patterns for handling component refs. The changes make the code cleaner and more maintainable. My main feedback is to use structured keys for new translation strings to improve maintainability.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

size-limit report 📦

Path Size
UMD 114.2 KB (+0.25% 🔺)
Auto 120.62 KB (+0.12% 🔺)
ESM - Core 25.41 KB (0%)
ESM - Core + Card 64.72 KB (0%)
ESM - Core + Dropin with Card 71.17 KB (0%)

@johnayeni johnayeni requested a review from ScottiBR January 9, 2026 15:57
@sonarqubecloud
Copy link

@johnayeni johnayeni marked this pull request as ready for review January 13, 2026 10:59
@johnayeni johnayeni requested a review from a team as a code owner January 13, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants