-
Notifications
You must be signed in to change notification settings - Fork 165
Add support for econtext_atm alternative reference #3749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add support for econtext_atm alternative reference #3749
Conversation
🦋 Changeset detectedLatest commit: 3a14d3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for adyen-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @johnayeni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on extending the functionality and improving the robustness of the Econtext payment method integration. It introduces the capability to handle an Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for an alternative reference for econtext_atm payments, which changes the information displayed on the voucher. It also includes significant refactoring across several components to improve type safety and adopt modern React hook patterns for handling component refs. The changes make the code cleaner and more maintainable. My main feedback is to use structured keys for new translation strings to improve maintainability.
packages/lib/src/components/Econtext/components/EcontextVoucherResult/EcontextVoucherResult.tsx
Outdated
Show resolved
Hide resolved
size-limit report 📦
|
packages/lib/src/components/Econtext/components/EcontextVoucherResult/EcontextVoucherResult.tsx
Outdated
Show resolved
Hide resolved
packages/lib/src/components/internal/PersonalDetails/PersonalDetails.test.tsx
Show resolved
Hide resolved
|



📋 Pull Request Checklist
📝 Summary
This PR adds support for the
alternativeReferencefield to theEcontextvoucher result.Econtextsupports 5 tx variants and theecontext_atmvariant now supports analternativeReferencefield. If this field is present in the payment action for the component, the voucher result is displayed differently.🧪 Tested scenarios
🔗 Related GitHub Issue / Internal Ticket number
COSDK-772
Closes: