Develop #161
Merged
Develop #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(It's not used yet)
4/3, not 3/3. taking (normalized) 2/3 step each time,
-> the ghost cells aren't in yet though. changes to grid.cpp will support any variation of the dipole grid, from dipole to dipole6. Any number, really.
rearrange where inputs are checked too.
latitudes are backwards now???
… (probably won't be used)
it's weird to do it this way, but it works
and a comment describing what's going on.
- clean up comments & report statements (typos) - lay down baselats in the same order as geo grid, make interpolation easier later!
- the order stuff was placed was weird. - correct comments too
- Pretty sure this is correct...
forgot to commit this earlier. Scale the exp_q_dist by nAlts, not nAlts/2 We can also switch to q_Start (and 0), instead of q_s and q_N
in an effort to try and figure out why its wrong...
…l vars if a var within a function has the same name as a global & it changes the value, let's just be really clear it's only the **local** var that should be changed.
found a couple unused variables, and some that shared names w others
holy crap this was hard to find. Dipole looks (mostly) good now
> this is "bad github practice" but there were some changes that got forgotten in previous commits. whoops. it's all going to the same place anyways, as they say :)
This could break old input files, watch out! Seems ok on my end though...
…n mag_grid also move a couple functions around Just cleanin' up the code a bit
holy crap this has been a week of hunting the smallest bugs and chasing down the most miniscule of errors Dipole looks great now, for realz this time. Works in 1 & 3 dimensions This commit makes baselats_down a global var, and changes how the corners are put in. There are no longer any zeros, nans, etc. note, some configurations of the grid *can* result in nan's at the poles, but these are rare - code beforte this commit would have the last field line shifted one q-step lower than it should be. this makes everything even & makes sure the centers and corners are lined up.
whoops. aether doesn't need this lol
Dipole grid for the ions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Get the latest develop branch into the ion advection branch so that the ion advection along the field line can be developed.