fixed labelForTutorialSwipe alignment on iPhone 6 devices by using windo... #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndow width instead of the device width of previous devices. fixed tutorialLabel which would get cutoff when exceeding a certain number of characters and height.
|
Hi @AfonsoTsukamoto , will this get pulled in? I'm using cocoa pods to pull in your controller, and have this fix implemented in my local, but if I do a pod update, it gets overwritten. Not sure a better way to manage this other than trying to make sure this gets pulled in! |
|
Hey! Sorry for the (longgggg) delay. I'll review it now. |
| {20.0, ((self.window.frame.size.height) - (60.0 + 20.0))}, // 60 = height of the label. 20 is the margin to the bottom. | ||
| {280.0, 60.0} | ||
| {0, ((self.window.frame.size.height) - (60.0 + 20.0))}, // 60 = height of the label. 20 is the margin to the bottom. | ||
| {self.window.frame.size.width, 60.0} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed labelForTutorialSwipe alignment on iPhone 6 devices by using window width instead of the device width of previous devices. fixed tutorialLabel which would get cutoff when exceeding a certain number of characters and height.