Skip to content

[WIP][feature enhancement] Add all supported litellm models to "other" option in cli/wiz #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

adubatl
Copy link

@adubatl adubatl commented Feb 22, 2025

Pausing this - I need to make sure my local env works more deterministically rq. Getting tests tidied up and testing on both my platforms before I return to this. should help clean up the PR too!

📥 Pull Request

Round two - begin! Would love additional comments since I reworked some things and cleaned up the commit history I had to perma-close the original. #326.

Opted for the route suggested by @bboynton97 of keeping the preferred models, but having the option of trying anything liteLLM supports via the other option in the cli/wiz

📘 Description

  • Swapped inquirer for questionary, this provides searchable list support for the litellm-generated list of models.
  • updated tests to handle new library
  • updated some tests to pass on windows when running tox -m quick. Mostly file-handling tweaks

🧪 Testing
tox passing locally 🥂
going to run some manual tests as well, but I'm by no means an AgentStack power user.
I also want to add some test coverage around the new list of models, or at least a script to manually test or spot check a few

…/wiz flows, but also for searchable models)

use_shortcuts is a bummer with search, so bye

make the filters behave

use a real list of the providers

we dont need preferred models honestly, it all lives in the lite llm package anyway

cleanup linting/comment changes, move all models list to the other option

cleanup cli/wizard implementation and move a util to utils

get tests passing and do a little more pr noise cleanup

formatting noise

formatting noise

formatting noise

formatting noise

formatting noise

formatting noise

formatting noise

formatting noise

formatting noise

formatting noise

formatting noise

formatting noise

formatting noise

format manually something is weird.

missing double-quote

get tests passing and do a little more pr noise cleanup

formatting noise

formatting noise

formatting noise

formatting noise

formatting noise

formatting noise

formatting noise

formatting noise

formatting noise

formatting noise

formatting noise

formatting noise

format manually something is weird.
@adubatl adubatl closed this Feb 24, 2025
@bboynton97
Copy link
Contributor

i'd like to reevaluate this. at the very least using questionary, as that was a better UX than inquirerer

@bboynton97 bboynton97 reopened this Mar 5, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets drop this file though, as we should be using uv instead of poetry

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

howdy! sorry to go dark on y'all, sick + flooding crawlspace -.-

Inquirer was in there, so I assumed just swap em out, what is the poetry-lock doin in there? Asking for this guy I know whos never done dev work on a windows or dealt with multiple pyenvs locally lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants