-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renames agenta app Dockerfiles to non-trivial names #1739
base: dev
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…rfile for backward compatibility
@aybruhm It is expected that the oss tests fail here, since they are using the old backend hosted in oss.agenta.ai (which expects The QA therefore needs to test these manually:
We do not need to test new sdk on old backend (Since that should not work). In the future, I think we need to move the dockerfile creation to the backend. It's just nice to have it in the FE for debugging for now (although, not sure if this is used at all). |
Ah, got it. 😅 Thank you for clarifying. |
@aybruhm updated the comment |
@aybruhm I have also reverted the change you made, it looks to me that it introduces and error |
🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to move all the serve
operations and files inside of a .agenta
folder to avoid any conflicts.
…age build preparation
I'm not sure if I understand what you mean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, @mmabrouk ! I've QA'ed oss and cloud staging with the changes, and everything looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTEThis is ready to be merged pre-release. |
Closes #1738
Please QA