-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): create evaluation model testset overlapping issue #2231
base: dev
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ashrafchowdury
- I understand this PR adds a search feature right, but I could not understand the testset overlapping issue, the issue does not explain the problem clearly. Can you please explain it and the solution
- The search feature only works in human evaluation but not in automatic evaluation
- The tests are failing
…reate-evaluation-model-testset-issue
Deployment failed with the following error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @ashrafchowdury. It looks like the New Evaluation Modal has already been updated, but the Human Evaluation Modal has not. To keep this PR focused, let's limit its scope to updating the Human Evaluation Modal only
Description
This PR aims to fix the testset overlapping issue in the create new evaluation model, and also added search feature in the component so that finding testsets gets easier.
Related Issue
Closes AGE-1055