adding `ymax-alpha-1` proposals #260

amessbee · 2025-07-18T10:41:21Z

Closes #258

adopt a passed proposal

When a proposal passes on agoric-3 Mainnet, it should be included in the history that this synthetic image tracks.

before this PR, change any fromTag using latest (such as a3p-integration) to use a fixed version (otherwise they will fail when this PR changes latest and they pick it up)
before merging this PR, include a link to a PR that adopts its fromTag use-${proposalName} (where proposalName is the part of the agoric-3-proposals proposal directory name after the colon, cf. a3p-integration/proposals)
after this PR merges, merge that other PR

image building process

This should not affect other repos but be prepared that it might.

@agoric/synthetic-chain library

These need to be published to be consumed in other apps. It's not yet on 1.0 so breaking changes are allowed, but please don't make them gratuitously.

indicate in the PR description when you expect these to be published and by whom (it's currently a manual process)

tooling improvements

As long as it passes CI it should be fine.

semanticdiff-com · 2025-07-18T10:41:24Z

Review changes with

Changed Files

File	Status
.gitignore	Unsupported file format
proposals/100:ymax-alpha1/.gitignore	Unsupported file format
proposals/100:ymax-alpha1/.yarnrc.yml	0% smaller
proposals/100:ymax-alpha1/Makefile	Unsupported file format
proposals/100:ymax-alpha1/README.md	Unsupported file format
proposals/100:ymax-alpha1/eval.sh	Unsupported file format
proposals/100:ymax-alpha1/package.json	0% smaller
proposals/100:ymax-alpha1/submission/b1-06934dae7861f141432664315f14def6ca9dc2790dba3fab70246ae1d1cf4f9bbe4688406eb9b8e60153da16a89af4d3105f17d6a40873d836f74051c7c9e954.json	0% smaller
proposals/100:ymax-alpha1/submission/b1-1cfec33f0aea5488aefbbe6b861bf5211081ea139f1bc8bd03540c7b35d6dcb7342b5be675e183cbf2b9d3cd0f9098a2a5e4cf349ce56f11df33835d26d938d7.json	0% smaller
proposals/100:ymax-alpha1/submission/b1-2127a1e2f296c89c04280272f3e110f4e4b56d98804200d001c9e49d9926e7d3130c81995ab3976a5962cd2199abeb2915a6c458c8700a2116bc6c01639e1f73.json	0% smaller
proposals/100:ymax-alpha1/submission/b1-d217fb17508ebe5c94e9ab432a9d6f5aea5fba810f7e5d7cc1785a6235e378e8eb117199624eb2f0061fc39126150d6f833617d0c2c26a979b36b0bb81d88a61.json	0% smaller
proposals/100:ymax-alpha1/submission/eval-access-token-setup-permit.json	0% smaller
proposals/100:ymax-alpha1/submission/eval-access-token-setup.js	0% smaller
proposals/100:ymax-alpha1/submission/eval-chain-info-permit.json	0% smaller
proposals/100:ymax-alpha1/submission/eval-chain-info.js	0% smaller
proposals/100:ymax-alpha1/submission/eval-ymax0-permit.json	0% smaller
proposals/100:ymax-alpha1/submission/eval-ymax0.js	0% smaller
proposals/100:ymax-alpha1/test.sh	Unsupported file format
proposals/100:ymax-alpha1/test/deploy.test.js	0% smaller
proposals/100:ymax-alpha1/tx.json	0% smaller
proposals/100:ymax-alpha1/yarn.lock	Unsupported file format
proposals/101:ymax-usdc-resolve/.gitignore	Unsupported file format
proposals/101:ymax-usdc-resolve/.yarnrc.yml	0% smaller
proposals/101:ymax-usdc-resolve/Makefile	Unsupported file format
proposals/101:ymax-usdc-resolve/README.md	Unsupported file format
proposals/101:ymax-usdc-resolve/eval.sh	Unsupported file format
proposals/101:ymax-usdc-resolve/package.json	0% smaller
proposals/101:ymax-usdc-resolve/submission/b1-81c0224cb5466dfa9b5d14bc94d19ed1b0ca7aa47d22dadd0f538f14a59d70a596aa37850ec89aba796873f912708bd6144a91693e643af7a98602c70fbe052f.json	0% smaller
proposals/101:ymax-usdc-resolve/submission/eval-usdc-resolve-permit.json	0% smaller
proposals/101:ymax-usdc-resolve/submission/eval-usdc-resolve.js	0% smaller
proposals/101:ymax-usdc-resolve/test.sh	Unsupported file format
proposals/101:ymax-usdc-resolve/test/deploy.test.js	0% smaller
proposals/101:ymax-usdc-resolve/tx.json	0% smaller
proposals/101:ymax-usdc-resolve/yarn.lock	Unsupported file format

changeset-bot · 2025-07-18T10:41:24Z

⚠️ No Changeset found

Latest commit: d09489c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

amessbee · 2025-07-18T10:43:09Z

@mujahidkay even though this is still a draft, and can you review and provide feedback. Thanks.

proposals/100:ymax-alpha1/README.md

dckc · 2025-07-23T13:32:35Z

proposals/100:ymax-alpha1/test/deploy.test.js

+};
+
+// This test is skipped because it requires USDC which is not available until 101 passes.
+test.skip('ymax0 is in agoricNames.instance', async t => {


Don't skip the test.
Change the test to show that ymax0 is not in vstorage.

Also test that chain-info and access-token worked, i.e. that they put something in vstorage. As in multichain-testing

Checking for consistency of the poc brand between vbankAsset and brand is particularly helpful

turadg · 2025-07-23T13:49:30Z

Since #84 I don't think the Makefile is necessary.

scripts/add-proposal.ts 100 ymax-alpha1

If the files aren't in the cache it'l prompt you to fetch them so you might have to also do,

scripts/fetch-all-bundles.ts
rm -rf proposals/100*
scripts/add-proposal.ts 100 ymax-alpha1

dckc

I don't see any critical problems, so I was going to approve, but I realize: this includes 101, which hasn't passed yet.

So we have to either wait or split 101 out to its own PR.

dckc · 2025-07-24T05:56:54Z

proposals/100:ymax-alpha1/test/deploy.test.js

+        const bodyContent = parsedValue.body.slice(1); // Remove '#' prefix
+        const brandEntries = JSON.parse(bodyContent);
+
+        const poc26Entry = brandEntries.find(([name]) => name === 'PoC26');


Note that since we know they're entries of a keyed collection, this .find(...) is equivalent to fromEntries(brandEntries).PoC26

The steps to parse a vstorage value... repeating them makes it hard to tell whether each repetition is doing the same thing as the others.

Consider using these utilities from ymax.test.js in the a3p-integration test:

const getCellValues = ({ value }) => { return JSON.parse(value).values; }; const getCapDataStructure = cell => { const { body, slots } = JSON.parse(cell); const structure = JSON.parse(body.replace(/^#/, '')); return { structure, slots }; };

Then you can use something like this to get the brand or vbankAsset collection:

const instance = Object.fromEntries( getCapDataStructure(getCellValues(instanceRaw).at(-1)).structure, );

dckc · 2025-07-24T05:58:52Z

proposals/100:ymax-alpha1/test/deploy.test.js

+    brandKeys.forEach((key, index) => {
+      console.log(`${(index + 1).toString().padStart(2, ' ')}. ${key}`);
+    });
+    console.log(`\nTotal brands: ${brandKeys.length}`);


why console.log rather than t.log?

dckc · 2025-07-24T06:01:03Z

proposals/100:ymax-alpha1/test/deploy.test.js

+
+    t.false(
+      instanceNames.includes('ymax0'),
+      'ymax0 should not be in vstorage yet',


"should not" is a little strong - it should be there; maybe "no ymax0 instance in vstorage yet" or some such.

dckc · 2025-07-24T06:02:00Z

proposals/100:ymax-alpha1/test/deploy.test.js

+    t.log('vBank board ID:', vBankBoardId);
+
+    t.is(brandBoardId, vBankBoardId, 'PoC26 brand board IDs should match');
+  } catch (error) {


why catch errors?

dckc · 2025-07-24T06:03:30Z

proposals/100:ymax-alpha1/test/deploy.test.js

@@ -0,0 +1,242 @@
+// @ts-check


I don't see anything wrong with this test, but it would be easier to be confident that it's right if it were more concise.

It's a bit concise now after using getCapDataStructure :)

dckc · 2025-07-24T06:07:02Z

proposals/101:ymax-usdc-resolve/Makefile

@@ -0,0 +1,47 @@
+# This Makefile is here to help you find out what went on the


did you end up using add-proposal.ts? if so, then you might as well get rid of the Makefile.

And I'm not inclined to check tx.json, so I have a mild preference for removing it from this PR. (not critical)

Using Makefile for now as I had already done what add-proposal.ts is supposed to do. Will be handy next time.

dckc · 2025-07-24T06:10:00Z

proposals/101:ymax-usdc-resolve/eval.sh

+echo "[$PROPOSAL] Checking if ymax0 instance is registered in agoricNames"
+AGORIC_NAMES=$(agd q vstorage data published.agoricNames.instance -o json)
+echo "$AGORIC_NAMES"
+
+if echo "$AGORIC_NAMES" | grep -q "ymax0"; then
+    echo "[$PROPOSAL] ymax0 found in agoricNames"
+else
+    echo "[$PROPOSAL] ERROR: ymax0 not found in agoricNames"
+    exit 1
+fi


This looks like a test; i.e. something that belongs in test.sh.

It also looks redundant w.r.t. 101...deploy.test.js

Yep, redundant and removed now.

dckc · 2025-07-24T06:13:21Z

proposals/101:ymax-usdc-resolve/README.md

@@ -0,0 +1,6 @@
+# CoreEvalProposal to deploy USDC resolve to fix ymax-alpha1


we can't land this until 101 passes

We can either

wait

move the 101 stuff to a separate PR and land the 100 stuff

important

Yes. I don't have a preference. Let me know if you do.

dckc · 2025-07-24T06:16:17Z

proposals/53:kread-start/mn2-start.test.js

+  };
+
+  // Retry up to 6 minutes (block time ~6s)
+  const maxTries = 60;


Why do we have to touch old proposals? Isn't the way their tests run fixed?

For some reason, this was failing, and I added a wait, and it passed CI. But looks like it's a depot issue. Partly discussed in slack thread.

wip: updates chore: try a bunch for vstorage chore: try a bunch for vstorage chore: test ymax0 instance after usdc resolves chore: adding more tests with agd fix: lint chore: update Makefil to get tx.json

chore: copied files from 87 fastusdc beta proposal

6bc3d09

amessbee changed the title ~~adding ymax alpha-1 proposals~~ adding ymax-alpha-1 proposals Jul 18, 2025

amessbee requested a review from mujahidkay July 18, 2025 10:42

amessbee force-pushed the ms/ymax-alpha1-proposals branch 2 times, most recently from 4df8e4b to 6580a0e Compare July 18, 2025 16:38

dckc reviewed Jul 23, 2025

View reviewed changes

proposals/100:ymax-alpha1/README.md Outdated Show resolved Hide resolved

dckc reviewed Jul 23, 2025

View reviewed changes

dckc reviewed Jul 24, 2025

View reviewed changes

amessbee added 2 commits July 24, 2025 16:46

chore: copy ymax alpha1 assets

8e6960a

chore: add ymax-usdc-resolve

d09489c

wip: updates chore: try a bunch for vstorage chore: try a bunch for vstorage chore: test ymax0 instance after usdc resolves chore: adding more tests with agd fix: lint chore: update Makefil to get tx.json

amessbee force-pushed the ms/ymax-alpha1-proposals branch from 6d323b8 to d09489c Compare July 24, 2025 11:48

amessbee marked this pull request as ready for review July 24, 2025 16:57

dckc self-requested a review July 25, 2025 16:33

		@@ -0,0 +1,47 @@
		# This Makefile is here to help you find out what went on the

		@@ -0,0 +1,6 @@
		# CoreEvalProposal to deploy USDC resolve to fix ymax-alpha1

adding ymax-alpha-1 proposals #260

Are you sure you want to change the base?

adding ymax-alpha-1 proposals #260

Uh oh!

Conversation

amessbee commented Jul 18, 2025

adopt a passed proposal

image building process

@agoric/synthetic-chain library

tooling improvements

Uh oh!

semanticdiff-com bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

amessbee commented Jul 18, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

turadg commented Jul 23, 2025

Uh oh!

dckc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

adding `ymax-alpha-1` proposals #260

adding `ymax-alpha-1` proposals #260

semanticdiff-com bot commented Jul 18, 2025 •

edited

Loading

changeset-bot bot commented Jul 18, 2025 •

edited

Loading