chore(SwingSet): Remove URL from kernel compartment endowments #11091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
39ed9f1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://579bf2b3.agoric-sdk.pages.dev |
| Branch Preview URL: | https://gibson-2025-03-kernel-compar.agoric-sdk.pages.dev |
kriskowal
approved these changes
Mar 8, 2025
kriskowal
requested changes
Mar 8, 2025
There was a problem hiding this comment.
Actually, we probably ought to unendow now while we can, pending endojs/endo#2635
|
Fair enough; done. |
gibson042
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #3273
Description
Fixes a longstanding but apparently not-yet-relevant typo.
Security Considerations
None known.
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
Skipping for this trivial change.
Upgrade Considerations
AFAIK, this should only affect code in the kernel and in local workers (the latter of which must not be affected or else we would already have found this).