refactor: suppress connectToNoble() in FastUSDC proposals in A3p tests #11240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Merged
mergify bot
added a commit
that referenced
this pull request
Apr 14, 2025
closes: https://github.com/Agoric/agoric-private/issues/305 ## Description The 'gtm' release is in A3P now, - https://github.com/Agoric/agoric-3-proposals/pull/230/files and included in the a3p-integration history. - #11233 ### Security Considerations n/a ### Scaling Considerations n/a ### Documentation Considerations n/a ### Testing Considerations See whether this is necessary, - #11240 ### Upgrade Considerations n/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #305
refs: #230
refs: #228
Description
Require a platform parameter when building the proposal for fastUSDC-GTM, so we can suppress the call to
connectToNoble()on A3P, where there is no Noble connections.Security Considerations
None
Scaling Considerations
None
Documentation Considerations
The proposal builder complains if it doesn't get a parameter. The only value it compares to is A3P-INTEGRATION.
Testing Considerations
This enabled adding proposal 89 to
agoric-3-proposals.Upgrade Considerations
Moving tests from
a3p-integrationtoagoric-3-proposalsunblocks preparing new releases. The affected upgrade has already been applied to mainNet.