refactor(SwingSet): Simplify conditions in mapVatSlotToKernelSlot #11668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
a775a7b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8fb3b320.agoric-sdk.pages.dev |
| Branch Preview URL: | https://gibson-2025-07-cleanup-vatke.agoric-sdk.pages.dev |
turadg
approved these changes
Nov 14, 2025
Member
turadg
left a comment
turadg
left a comment
There was a problem hiding this comment.
The only downside of the cond || is that TypeScript doesn't know to narrow Fail but this wasn't using throw anyway
gibson042
force-pushed
the
gibson-2025-07-cleanup-vatkeeper
branch
from
a775a7b to
5a043cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For readability, prefer short consequents before long alternatives and in particular the
$condition || Fail`…`pattern where possible.Best viewed while ignoring whitespace changes: ?w=1