Skip to content

invoke ymax resolver #12182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

invoke ymax resolver #12182

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8152ec7
type: export WalletStore
mhofman Nov 4, 2025
5d7e938
type(ymax-planner): fix resolve tx status type
mhofman Nov 4, 2025
913a91a
refactor(ymax-planner): pass walletStore along signingSmartWalletKit
mhofman Nov 4, 2025
2829412
refactor(ymax-planner): introduce ResolverHelperKit for tests
mhofman Nov 4, 2025
31e45e5
chore(portfolio-deploy): refactor portfolio test
mhofman Nov 5, 2025
7a0acbb
feat(portfolio-contract): deliver resolver service
mhofman Nov 5, 2025
d794090
feat(planner): add resolvePendingTxByInvocation implementation
mhofman Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion services/ymax-planner/src/resolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import { Fail, q } from '@endo/errors';
import type { SigningSmartWalletKit, WalletStore } from '@agoric/client-utils';
import type { OfferSpec } from '@agoric/smart-wallet/src/offers';
import type { TxStatus } from '@aglocal/portfolio-contract/src/resolver/constants.js';
import type { TxId } from '@aglocal/portfolio-contract/src/resolver/types';
import type { ResolverKit } from '@aglocal/portfolio-contract/src/resolver/resolver.exo.js';

type ResolveTxParams = {
signingSmartWalletKit: SigningSmartWalletKit;
Expand All @@ -26,7 +28,7 @@ const getInvitationMakers = async (wallet: SigningSmartWalletKit) => {
};
};

export const resolvePendingTx = async ({
export const resolvePendingTxByInvitation = async ({
signingSmartWalletKit,
txId,
status,
Expand All @@ -53,3 +55,24 @@ export const resolvePendingTx = async ({
// An offer error will result in a throw
await signingSmartWalletKit.executeOffer(action);
};

export const resolvePendingTxByInvocation = async ({
walletStore,
txId,
status,
proposal,
}: ResolveTxParams) => {
!proposal || Fail`Unexpected proposal ${q(proposal)}`;

const offerArgs = {
Copy link
Member

@dckc dckc Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

offerArgs seems like an odd name. There's no offer. might as well inline this record.

Copy link
Member Author

@mhofman mhofman Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the type is still TransactionSettlementOfferArgs for this, which is awkward, but I didn't change that part of the "code".

Happy to rename.

status,
txId,
};

const resolver = walletStore.get<ResolverKit['service']>('resolver');

// An invocation error will result in a throw
await resolver.settleTransaction(offerArgs);
};

export const resolvePendingTx = resolvePendingTxByInvitation;
Loading