Skip to content

partial order follow-up #12216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

partial order follow-up #12216

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44e27e1
fix(portfolio-contract): don't call fullOrder(0)
dckc Nov 13, 2025
17b5f6f
fix(portfolio-contract): don't reverse failure reasons
dckc Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/portfolio-contract/src/portfolio.flows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ const trackFlow = async (
const job: Job = { taskQty: moves.length, order };
const results = await runJob(job, runTask, traceFlow);
if (results.some(r => r.status === 'rejected')) {
const reasons = [...results].reverse().reduce((next, r, ix) => {
const reasons = results.reduce((next, r, ix) => {
if (r.status !== 'rejected') return next;
const errs: FlowErrors = {
step: ix + 1,
Expand Down Expand Up @@ -537,11 +537,12 @@ const stepFlow = async (
const { flow: moves, order: maybeOrder } = Array.isArray(plan)
? { flow: plan }
: plan;
const order = maybeOrder || fullOrder(moves.length);

traceFlow('checking', moves.length, 'moves');
moves.length > 0 || Fail`moves list must not be empty`;

const order = maybeOrder || fullOrder(moves.length);

for (const [i, move] of entries(moves)) {
const traceMove = traceFlow.sub(`move${i}`);
const way = wayFromSrcToDesc(move);
Expand Down
Loading