Skip to content

Upgrade @agoric/rpc to 0.10.0 to fix vstorage path issue for custom networks #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

rabi-siddique
Copy link
Contributor

@rabi-siddique rabi-siddique commented May 15, 2025

The PR does the following:

  • Upgraded @agoric/rpc from version 0.6.0 to 0.10.0 to fix issues with vstorage access with custom networks.
  • Resolved build failures that arose after the version bump.
  • Addressed UI regressions introduced by the update.

Context

wallet-app is showing errors when trying to access data from storage. It is using incorrect paths such as:

/custom/vstorage/data/published.agoricNames.instance

All paths should begin with /agoric/ instead of /custom/.
This misconfiguration occurs when selecting the xnet network from the dropdown in the UI.

Copy link

cloudflare-workers-and-pages bot commented May 15, 2025

Deploying wallet-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: fb10e49
Status: ✅  Deploy successful!
Preview URL: https://c0355460.wallet-app.pages.dev
Branch Preview URL: https://rs-fix-vstorage-path-issue.wallet-app.pages.dev

View logs

Copy link

socket-security bot commented May 15, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@rabi-siddique rabi-siddique force-pushed the rs-fix-vstorage-path-issue branch from 8ea9365 to 7cb16b3 Compare May 16, 2025 04:34
@rabi-siddique rabi-siddique force-pushed the rs-fix-vstorage-path-issue branch 2 times, most recently from 2f0f901 to 407545c Compare May 16, 2025 06:19
@rabi-siddique rabi-siddique force-pushed the rs-fix-vstorage-path-issue branch from 407545c to c9f32ee Compare May 16, 2025 10:42
@rabi-siddique
Copy link
Contributor Author

Encountering this error when running yarn test:

    ReferenceError: TextEncoder is not defined

       5 | // learn more: https://github.com/testing-library/jest-dom
       6 | import '@testing-library/jest-dom';
    >  7 | import Enzyme from 'enzyme';
         | ^
       8 | import Adapter from 'enzyme-adapter-react-16';
       9 |
      10 | Enzyme.configure({

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant