Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DropdownButtonFormField padding when ButtonTheme.alignedDropdown … #362

Merged
merged 1 commit into from
Mar 16, 2025
Merged

Fix DropdownButtonFormField padding when ButtonTheme.alignedDropdown … #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/dropdown_button2/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
- Use decoration hint text as the default value for dropdown button hints [Flutter core].
- Update SDK constraints: ">=3.4.0 <4.0.0"
- Fix DropdownButtonFormField clips text when large text scale is used [Flutter core].
- Fix DropdownButtonFormField padding when ButtonTheme.alignedDropdown is true [Flutter core].

## 3.0.0-beta.21

Expand Down
4 changes: 3 additions & 1 deletion packages/dropdown_button2/lib/src/dropdown_button2.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,9 @@ class _DropdownButton2State<T> extends State<DropdownButton2<T>> with WidgetsBin
}

final EdgeInsetsGeometry padding =
ButtonTheme.of(context).alignedDropdown ? _kAlignedButtonPadding : _kUnalignedButtonPadding;
ButtonTheme.of(context).alignedDropdown && widget._inputDecoration == null
? _kAlignedButtonPadding
: _kUnalignedButtonPadding;

final buttonHeight = _buttonStyle?.height ?? (widget.isDense ? _denseButtonHeight : null);

Expand Down
Loading