Skip to content

Idcat mobil verifications #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Idcat mobil verifications #608

wants to merge 9 commits into from

Conversation

entantoencuanto
Copy link
Collaborator

@entantoencuanto entantoencuanto commented Mar 20, 2025 •
edited by fblupi
Loading

🎩 What? Why?

This PR:

  • Fixes management of custom authorizations with ephemeral feature
  • Installs trusted-ids module to allow authenticate and authorize users with IdCAT Mòbil

📌 Related Issues

@entantoencuanto entantoencuanto mentioned this pull request Mar 20, 2025
Closed
2 tasks
@entantoencuanto
Copy link
Collaborator Author

Branch added to the repo, @fblupi

@fblupi fblupi temporarily deployed to decidim-barcelona-staging March 20, 2025 15:45 Inactive
fblupi
fblupi requested changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@fblupi fblupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change to update the overrides spec.

I've deployed it on the staging environment. To test it properly, ask Roxu how to access it and so on.

decidim-ephemeral_participation/lib/decidim/ephemeral_participation/engine.rb
@@ -17,7 +17,7 @@ class Engine < ::Rails::Engine
Decidim::AuthorizationHandler.include(Decidim::EphemeralParticipation::AuthorizationHandlerOverride)
Decidim::Admin::ComponentForm.include(Decidim::EphemeralParticipation::ComponentFormOverride)
Decidim::Admin::PermissionsForm.include(Decidim::EphemeralParticipation::PermissionsFormOverride)
Decidim::System::UpdateOrganizationForm.include(Decidim::EphemeralParticipation::UpdateOrganizationFormOverride)
Decidim::System::BaseOrganizationForm.include(Decidim::EphemeralParticipation::UpdateOrganizationFormOverride)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the spec/lib/overrides_spec.rb spec removing the entry for: /app/forms/decidim/system/update_organization_form.rb and including /app/forms/decidim/system/base_organization_form.rb.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@entantoencuanto Once you change it. I will approve the PR, as it seems to be working with the latest deployment, isn't it?

@fblupi fblupi temporarily deployed to decidim-barcelona-staging March 21, 2025 11:31 Inactive
@fblupi fblupi temporarily deployed to decidim-barcelona-staging March 21, 2025 12:59 Inactive
@rxnetwalker rxnetwalker had a problem deploying to decidim-barcelona-staging March 26, 2025 16:28 Failure
@fblupi fblupi temporarily deployed to decidim-barcelona-staging March 31, 2025 11:35 Inactive
@fblupi fblupi temporarily deployed to decidim-barcelona-staging April 2, 2025 11:33 Inactive
@fblupi fblupi temporarily deployed to decidim-barcelona-staging April 11, 2025 10:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fblupi fblupi fblupi requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BCN Integration with idCAT Mòbil
3 participants
@entantoencuanto @fblupi @rxnetwalker