Autoload patches with flickwerk #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
commented
Nov 21, 2024
app/decorators/controllers/alchemy/solidus/spree_admin_base_controller_decorator.rb
Outdated
Show resolved
Hide resolved
mamhoff
force-pushed
the
autoload-decorators
branch
2 times, most recently
from
705a799 to
c9473a5
Compare
mamhoff
force-pushed
the
autoload-decorators
branch
4 times, most recently
from
33d98bf to
641392a
Compare
|
This has the work from solidusio/solidus_support#94 and should pass once #120 is merged. |
mamhoff
force-pushed
the
autoload-decorators
branch
from
641392a to
48bbc38
Compare
tvdeyen
force-pushed
the
autoload-decorators
branch
from
48bbc38 to
6a13b13
Compare
mamhoff
force-pushed
the
autoload-decorators
branch
from
6a13b13 to
0f3abb8
Compare
mamhoff
force-pushed
the
autoload-decorators
branch
from
0f3abb8 to
a71f58f
Compare
This also tries require'ing `solidus_frontend` before we load the patch. Otherwise `flickwerk` does not find the patch in lib/frontend (because by the time it looks for the files, `solidus_frontend` is not yet loaded).
We don't need to keep a whole file for a single line of ActionView configuration.
mamhoff
force-pushed
the
autoload-decorators
branch
from
a71f58f to
e000fb0
Compare
Newer versions of Alchemy do not accidentally load the Admin Base Controller in an initializer, so for new Alchemy versions this will be handled by Flickwerk. In order versions though, the `Spree::Admin::BaseController` is loaded to early in the startup process and thus we need to load the patch manually.
This brings flickwerk support
mamhoff
force-pushed
the
autoload-decorators
branch
from
e000fb0 to
121791b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all the patches to core Solidus or the main app to places where they will be picked up by solidus_support.