Fixed 3 broken links, 1 still needs fixing. #2924
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2924 +/- ##
=======================================
Coverage 95.97% 95.97%
=======================================
Files 232 232
Lines 6279 6279
=======================================
Hits 6026 6026
Misses 253 253 ☔ View full report in Codecov by Sentry. |
| @@ -1,6 +1,7 @@ | |||
| # == In this configuration, you set up Alchemy's menu names. | |||
| # | |||
| # For further information please see http://guides.alchemy-cms.com/stable/menus.html | |||
| # TODO: Ensure there is a working link with explanation on how menu's are constructed. Link below is broken. | |||
| # For further information please see http://guides.alchemy-cms.com/menus.html | |||
There was a problem hiding this comment.
There is no guide unfortunately. Can we remove the comment altogether for now?
There was a problem hiding this comment.
I am a new person testing out Alchemy having this undocumented is super confusing as this is very core to any webpage.
After looking a bit on the code I found what to do.
What about instead having the links say: To create the views for the menu use rails g alchemy:menus and render the menu with <%= render_menu('menu_name') %>
At least this comment with get the people going for common use cases.
|
This pull request has not seen any activiy in a long time. |
|
This pull request has not seen any activiy in a long time. |
What is this pull request for?
This fixes broken links.
Except for one, in
menus.yml.tt, I've added a todo for that because this readme does not exist? Should/Does it? It's not available at the moment and i needed it. Because i have no clue how to make menus just yet.Notable changes (remove if none)
Fixed links in comments.
Checklist