Use turbo frame and stream to create element #3053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to use `alchemy_form_for` in `turbo_frame_tag`s, we need to be able to disable the Ajax remote form feature from `rails-ujs`.
tvdeyen
force-pushed
the
turbo-frames-create-element
branch
2 times, most recently
from
01e72ae
to
9a9c081
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3053 +/- ##
=======================================
Coverage 96.63% 96.63%
=======================================
Files 236 236
Lines 6331 6331
=======================================
Hits 6118 6118
Misses 213 213 ☔ View full report in Codecov by Sentry. |
Handle Turbo related events to support `turbo_frame_tag`s in Dialogs.
By responding with a turbo-stream instead of js.erb, we can replace the old Rail-UJS data-remote with a turbo-frame.
tvdeyen
force-pushed
the
turbo-frames-create-element
branch
from
9a9c081
to
dd93836
Compare
tvdeyen
changed the title
sascha-karnatz
approved these changes
Sep 26, 2024
|
Looks pretty good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
By responding with a turbo-stream instead of js.erb,
we can replace the old Rail-UJS data-remote with a
turbo-frame.
Notable changes
In order to use
alchemy_form_forinturbo_frame_tags,we need to be able to disable the Ajax remote form feature
from
rails-ujs.Checklist