Fix menu-actions GTK callback pointer handling#4925
Open
B2krobbery wants to merge 3 commits intoAlexays:masterfrom
Open
Fix menu-actions GTK callback pointer handling#4925B2krobbery wants to merge 3 commits intoAlexays:masterfrom
B2krobbery wants to merge 3 commits intoAlexays:masterfrom
Conversation
B2krobbery
force-pushed
the
fix-menu-actions-pointer
branch
3 times, most recently
from
2c2f6f9 to
69b3e5e
Compare
B2krobbery
force-pushed
the
fix-menu-actions-pointer
branch
from
69b3e5e to
3cfb622
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix pointer lifetime handling for menu-actions GTK callbacks.
The previous implementation passed a temporary pointer to the GTK callback.
This patch ensures the pointer remains valid by referencing the stored
string from menuActionsMap_.
Verified build locally and tested with Waybar.