Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added translations #5

Merged
merged 7 commits into from
Jan 25, 2023
Merged

Added translations #5

merged 7 commits into from
Jan 25, 2023

Conversation

boerniee
Copy link

Hello,
I have added vue-i18n for translations. The language to use will be determined by the browsers language.
Currently only english and german language is translated.

Not included is formatting dates and fixing the currency formatting.

@boerniee boerniee changed the title I18n Added translations Jan 13, 2023
@AlfHou
Copy link
Owner

AlfHou commented Jan 24, 2023

Thank you for your PR :)
As mentioned, there are some keys in German that should be in English, it would be great if you could double check all the keys. Also, there are some parts that are not translated to German (See attached screenshots. Might be more as well).

Lastly, it would be nice with an option in the settings to change the language. If you don't feel like doing it, I can also add it later.

image
image
image

@solluh
Copy link

solluh commented Jan 25, 2023

I'd really love to do that.
Problem: I'm a newbee, who don't know how to make changes. Do I have to make a fork of boernies fork and do a new pull request?

@solluh
Copy link

solluh commented Jan 25, 2023

This can't be the way, can it?

@AlfHou
Copy link
Owner

AlfHou commented Jan 25, 2023

The above comment was directed to @boerniee, but it's great that you want to contribute.

If you want to make changes to someone else's PR you're correct in that you would have to fork from their fork and then open a new PR :)

Feel free to reach out if you get stuck.

@solluh
Copy link

solluh commented Jan 25, 2023

Sorry, I'm too dumb for this.
After forking boerniee's fork I was looking for the file de.json in ui/src/locals - nothing...

@AlfHou
Copy link
Owner

AlfHou commented Jan 25, 2023

You probably just need to check out the proper branch. Run git checkout -b i18n

@boerniee
Copy link
Author

Hi @AlfHou,
sorry I have translated the missing parts and also changed the english translations.
I have also thought about a setting for the user. But for the sake of simplicity I have started with the browsers setting. It would be nice to have user setting to change it if you would like to user another language! You can add it also.
What we also should add later on is lazy loading for the translation files.

@AlfHou
Copy link
Owner

AlfHou commented Jan 25, 2023

@boerniee no worries, looks good now. Let's just get it merged, then we can iterate on it in the future. Thank you for the contribution :)

@AlfHou AlfHou merged commit ba27697 into AlfHou:master Jan 25, 2023
@GoNzCiD
Copy link

GoNzCiD commented Jul 28, 2023

Is not possible to set a default language by user?

@AlfHou
Copy link
Owner

AlfHou commented Jul 28, 2023

@GoNzCiD For now it uses the browser locale. I have a PR #43 where I've started working on a user setting to pick this, but it's currently a bit on hold.

@thehijacker
Copy link

I would love to do Slovenian translation. Where to start?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants