MNT-24883 sourcefile name added in transform options #3379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
repository/src/main/java/org/alfresco/repo/rendition2/RenditionDefinition2.java
Fixed
Show fixed
Hide fixed
repository/src/main/java/org/alfresco/repo/content/transform/LocalTransformImpl.java
Fixed
Show fixed
Hide fixed
bsayan2
requested review from
damianujma,
kushal-banik-hyland,
jakubkochman and
SatyamSah5
repository/src/main/java/org/alfresco/repo/content/transform/LocalTransformImpl.java
Outdated
Show resolved
Hide resolved
damianujma
requested changes
Jun 11, 2025
| @@ -155,10 +161,13 @@ protected void transformImpl(ContentReader reader, | |||
| transformOptions.put(SOURCE_NODE_REF, sourceNodeRef.toString()); | |||
| } | |||
|
|
|||
| String filename = transformUtil.getFilenameFromNodeRef(sourceNodeRef, true); | |||
There was a problem hiding this comment.
I would use just nodeSerivce
| // Build an array of option names and values and extract the timeout. | ||
| long timeoutMs = 0; | ||
| int nonOptions = transformOptions.containsKey(RenditionDefinition2.TIMEOUT) ? 1 : 0; | ||
| int size = (transformOptions.size() - nonOptions + 3) * 2; | ||
| int argAdditionalSize = StringUtils.isNotEmpty(filename) ? 4 : 3; |
There was a problem hiding this comment.
Can't we add SOURCE_FILENAME to transformOptions to simplify it?
repository/src/main/java/org/alfresco/repo/content/transform/LocalTransformServiceRegistry.java
Fixed
Show fixed
Hide fixed
| @@ -71,6 +72,7 @@ | |||
| private Map<String, LocalTransform> localTransforms = new HashMap<>(); | |||
| } | |||
|
|
|||
| private NodeService nodeService; | |||
Check warning
Code scanning / PMD
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. Warning
| @@ -205,6 +206,9 @@ | |||
| @Mock | |||
| private MimetypeMap mimetypeMap; | |||
|
|
|||
| @Mock | |||
| private NodeService nodeService; | |||
Check warning
Code scanning / PMD
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. Warning test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending source file name in transform options.
core aio pr: Alfresco/alfresco-transform-core#1081
tests branch : fix/MNT-24883-transformoptions-test
test cases successful pipeline : alfresco-community-repo/actions/runs/15527733234