New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-8694] Cleanup of visibility rules for extensions in ACA #4140

Merged

swapnil-verma-gl merged 26 commits into develop from dev-acs-8694-cleanup-visible-rules

Feb 25, 2025

Contributor

swapnil-verma-gl commented Sep 25, 2024 •

edited

Loading

JIRA ticket link or changeset's description

https://hyland.atlassian.net/browse/ACS-8694

Updated ACA extensions config to use array based visibility rules instead of string based. Also removed various unused rules

This is a breaking change

swapnil-verma-gl requested review from DenysVuika and MichalKinas

September 25, 2024 07:27

swapnil-verma-gl added breaking change do not merge labels

swapnil-verma-gl marked this pull request as ready for review

September 26, 2024 07:49

Contributor Author

swapnil-verma-gl commented Sep 26, 2024

This PR should not be merged to develop, before the merge of #4139 to this branch

AleksanderSklorz reviewed

View reviewed changes

docs/extending/rules.md Outdated Show resolved Hide resolved

AleksanderSklorz reviewed

View reviewed changes

projects/aca-shared/rules/src/app.rules.spec.ts Outdated Show resolved Hide resolved

AleksanderSklorz reviewed

View reviewed changes

projects/aca-shared/rules/src/app.rules.spec.ts Outdated Show resolved Hide resolved

AleksanderSklorz reviewed

View reviewed changes

projects/aca-shared/rules/src/app.rules.spec.ts Outdated Show resolved Hide resolved

AleksanderSklorz reviewed

View reviewed changes

projects/aca-shared/rules/src/app.rules.spec.ts Outdated Show resolved Hide resolved

AleksanderSklorz reviewed

View reviewed changes

projects/aca-shared/rules/src/app.rules.spec.ts Outdated Show resolved Hide resolved

Contributor

AleksanderSklorz commented Oct 10, 2024

Great work @swapnil-verma-gl with cleaning up of these rules :D

Contributor Author

swapnil-verma-gl commented Oct 11, 2024

This PR should not be merged to develop, before the merge of #4139 to this branch

#4139 merged to this branch. This PR can now be merged to develop after sufficient code review approvals. Removing 'Do not merge' label

swapnil-verma-gl removed the do not merge label

AleksanderSklorz approved these changes

View reviewed changes

swapnil-verma-gl force-pushed the dev-acs-8694-cleanup-visible-rules branch from deb240e to dab8da7 Compare

November 4, 2024 08:27

sonarqubecloud bot commented Nov 6, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

dominikiwanekhyland approved these changes

View reviewed changes

swapnil-verma-gl mentioned this pull request

[ACS-9158] Remove 'View Details' button from node Details page #4351

Merged

nikita-web-ua approved these changes

View reviewed changes

swapnil-verma-gl force-pushed the dev-acs-8694-cleanup-visible-rules branch from 4ea6dfb to 043424e Compare

January 31, 2025 06:47

swapnil-verma-gl added 8 commits

February 24, 2025 17:22


          [ACS-8694] Updated occurrences of visible in extensions.json to use a…

6a98b6b

…rrays instead of single strings. Cleaned up rules in aca-content.module.ts


          [ACS-8694] Removed extra commas

08000dc


          [ACS-8694] Broke down canDelete rule into seperate entities

07cd6de


          [ACS-8694] Fixed typo for notEmpty rule

2d27014


          [ACS-8694] Fixed rule for edit offline

e4c6179


          [ACS-8694] Updated extension.schema.json

c1dc0ba


          [ACS-8694] Updated extension.schema.json

1ee7f6a


          [ACS-8694] Fixed rule for manage versions context menu item

ac636b2

swapnil-verma-gl and others added 17 commits

February 24, 2025 17:22


          [ACS-8694] Fixed rule for manage versions and manage permissions

67ddc74


          [ACS-8694] Added rules.canManageFolderRules

725a72c


          [ACS-8694] Fixed typo

1043ebc


          [ACS-8694] Updated visibility rules for folder rules and AOS plugin

0f4cecf


          [ACS-8694] Updated extension.schema.json

cd738be


          [ACS-8694] Updated existing rules to use !isTrashcan() instead of isN…

21c6a3d

…otTrashcan()


          [ACS-8694] folder-rules.plugin.json now uses arrays for controlling v…

6fd70d4

…isibility


          [ACS-8694] Updated app.extensions.schema

c1cd4b9


          [ACS-8694] Removed unused rules

df6ec85


          [ACS-8694] Added unit tests for canToggleFileLock

5a9b8c5


          [ACS-8694] Added rules-list.md

14c6a88


          [ACS-8694] Revert unneeded project.json change

6aff383


          [ACS-8694] Fixed toggleEditOffline rule

00492d8


          [ACS-8694] Added migration guide (#4139)

c97400b

* [ACS-8694] Added migration guide

* [ACS-8694] Fixed typo

* [ACS-8694] Added missing rule migration. Fixed incorrect rule migration. Fixed typos


          [ACS-8694] Code review finding - Replaced instance of any

143de80


          [ACS-8694] Code review finding - Updated rules.md. Removed duplicatio…

b280a36

…n of rules list from rules-list.md. Added pointer to rules-list.md under tips section


          [ACS-8694] Fixed build issue

5c06c18

swapnil-verma-gl force-pushed the dev-acs-8694-cleanup-visible-rules branch from 043424e to 5c06c18 Compare

February 24, 2025 11:55


          [ACS-8694] Removed unneeded isNotDetails rule

122ce06

sonarqubecloud bot commented Feb 24, 2025

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

swapnil-verma-gl merged commit f1c4dcf into develop

27 checks passed

swapnil-verma-gl deleted the dev-acs-8694-cleanup-visible-rules branch

February 25, 2025 11:30

swapnil-verma-gl added a commit that referenced this pull request


          Revert "[ACS-8694] Cleanup of visibility rules for extensions in ACA (#…

11145d0

…4140)"

This reverts commit f1c4dcf.

swapnil-verma-gl added a commit that referenced this pull request


          Rollback visibility rules cleanup (#4426)

2efea8c

* Revert "[ACS-9369] Updated rule-migration-guide.md to include missed rule (#4420)"

This reverts commit b3e2af7.

* Revert "[ACS-9369] Resolved issues where visibility rules with a single element array would log errors (#4416)"

This reverts commit 4e33f11.

* Revert "[ACS-8694] Cleanup of visibility rules for extensions in ACA (#4140)"

This reverts commit f1c4dcf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nikita-web-ua nikita-web-ua approved these changes

AleksanderSklorz AleksanderSklorz approved these changes

dominikiwanekhyland dominikiwanekhyland approved these changes

DenysVuika Awaiting requested review from DenysVuika

MichalKinas Awaiting requested review from MichalKinas

Labels

breaking change