AAE-33589 Move POST request for tasks list data to ngAfterViewInit #10793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomson7777
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
|
dsibilio
changed the title
DenysVuika
reviewed
Apr 16, 2025
|
|
||
| ngAfterViewInit() { |
There was a problem hiding this comment.
it should be ngOnInit
- Use ngOnInit for data fetching and initialization that does not depend on the view being fully rendered.
- Use ngAfterViewInit for logic that requires the view to be fully initialized.
- Refactoring your code to ngOnInit in this case would likely improve the performance and responsiveness of your component.
dsibilio
requested changes
Apr 17, 2025
There was a problem hiding this comment.
Tested on spare-02 and it does not work as expected.
Console error log:
ERROR Error: NG0203
Vt https://hxps-spare-02.studio.dev.experience.hyland.com/admin/chunk-GFFQMQQF.js:764
TI https://hxps-spare-02.studio.dev.experience.hyland.com/admin/chunk-GFFQMQQF.js:768
it https://hxps-spare-02.studio.dev.experience.hyland.com/admin/chunk-GFFQMQQF.js:772
ngAfterViewInit https://hxps-spare-02.studio.dev.experience.hyland.com/admin/chunk-GFFQMQQF.js:986Behaviour is that we get stuck on the spinner while trying to load the view:
After reverting the image to the original rc one then it works, so it's definitely related to this change.
|
Closing this in favor of #10813 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Columns filtering logic is executed to quickly.
What is the new behaviour?
Columns filtering logic is executed in right time, when all from schema are loaded.
Does this PR introduce a breaking change? (check one with "x")