Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue 309] Added containsQueryParamsMatching(...) matcher. #327

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcarti
Copy link

@mcarti mcarti commented Sep 7, 2020

Checklist

  • I've checked that all new and existing tests pass
  • I've updated the documentation if necessary
  • I've added an entry in the CHANGELOG to credit myself

Description

New matcher added: containsQueryParamsMatching(...). This matcher checks the presence of a list of parameters matching the RegExs given in a dictionary.

Motivation and Context

I suggested to share this new matcher in the issue #309.
The need is for checking the presence of dynamic parameters as timestamps or languages for example.
Since there was no entry in the documentation for the containsQueryParams matcher, I didn't add one for this matcher.

@mcarti
Copy link
Author

mcarti commented Sep 7, 2020

Hello
The Job #845.20 failed with the error:

Test Case '-[NSURLSessionTests test_NSURLSessionEphemeralConfig]' started.

/Users/travis/build/AliSoftware/OHHTTPStubs/Tests/OHHTTPStubsTests/NSURLSessionTests.m:199: error: -[NSURLSessionTests test_NSURLSessionEphemeralConfig] : Asynchronous wait failed: Exceeded timeout of 0.5 seconds, with unfulfilled expectations: "NSURLSessionDataTask completed".

Test Case '-[NSURLSessionTests test_NSURLSessionEphemeralConfig]' failed (0.868 seconds).

It doesn't seem to be related to the object of the PR, more a network issue. Is there a way to relaunch the build chain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant