-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tooling (Ruby, Pods, Deployment Targets) #368
Open
AliSoftware
wants to merge
16
commits into
master
Choose a base branch
from
tooling-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Except for `CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER` and `ENABLE_MODULE_VERIFIER`
And migrate them to use NSURLSession
Deployment Target, NSURLSession instead of NSURLConnection…
Deployment Target, NSURLSession instead of NSURLConnection…
This was referenced Mar 10, 2024
AliSoftware
force-pushed
the
tooling-update
branch
2 times, most recently
from
March 11, 2024 00:12
3b4dfca
to
b8b5359
Compare
AliSoftware
force-pushed
the
tooling-update
branch
from
March 11, 2024 00:21
b8b5359
to
b17065a
Compare
Liquidsoul
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
.podspec
andPodfiles
for Xcode 15.2+ minimumsNSURLConnection
calls in testsPodfile
,NSURLConnection
->NSURLSession
, …)cc @Liquidsoul I just noticed you already implemented some of this in #367 and #366; I only saw those branches after I started doing the work, but figured I'd finish my work and submit my version of the PR containing everything.