-
Notifications
You must be signed in to change notification settings - Fork 38
[WIP][EP][Failover] Migrate out alive requests when part of ep unit is down #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
migration_policy: MigrationPolicy) -> List[Tuple[str, str]]: | ||
src_instance_infos, dst_instance_infos = self.migration_base_filter.filter_instances(instance_info.values()) | ||
migration_policy: MigrationPolicy, | ||
skip_broken_unit: bool = True) -> List[Tuple[str, str]]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why add skip_broken_unit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For migration with MigrationType == FAILOVER_MIGRATION, we cannot filter out BROKEN instances since they are the source of migration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skip_broken_unit is deleted.
except Exception as e: | ||
log_instance_exception(e, dst_instance_id, "migrate_out", migrate_out_request.request_id) | ||
migrated_request_list.extend(migrated_request) | ||
if len(migrated_request) == 0 and migrate_out_request.eom: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is eom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while self.has_migration_slot() and (not migrate_out_request.eom):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
llumnix/manager.py
Outdated
dst_instance_actor = self.instances[dst_instance_id] | ||
asyncio.create_task( | ||
asyncio_wait_for_ray_remote_call_with_timeout( | ||
self.instances[src_instance_id].migrate_out, | ||
dst_instance_actor, dst_instance_id, migration_type | ||
) | ||
) | ||
|
||
if not exist_failover_migration_task: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not put these logic in push migrations? if len(failover_migration_tasks) >0, return empty normal_migratio_tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
test_request_trace[rayqueue-engine_BladeLLM-/mnt/model/Qwen2.5-7B]
test_request_trace[zmq-engine_BladeLLM-/mnt/model/Qwen2.5-7B]
|
test_request_trace[rayqueue-engine_BladeLLM-/mnt/model/Qwen2.5-7B]
test_request_trace[zmq-engine_BladeLLM-/mnt/model/Qwen2.5-7B]
|
test_request_trace[rayqueue-engine_BladeLLM-/mnt/model/Qwen2.5-7B]
test_request_trace[zmq-engine_BladeLLM-/mnt/model/Qwen2.5-7B]
|
bc47dc2
to
db3b6e6
Compare
test_request_trace[rayqueue-engine_vLLM-/mnt/model/Qwen2.5-7B]
test_request_trace[zmq-engine_vLLM-/mnt/model/Qwen2.5-7B]
|
test_simple_benchmark[engine_BladeLLM-False-zmq-False-False-/mnt/model/Qwen2.5-7B]
test_simple_benchmark[engine_BladeLLM-True-zmq-False-False-/mnt/model/Qwen2.5-7B]
test_simple_benchmark[engine_BladeLLM-False-rayqueue-False-False-/mnt/model/Qwen2.5-7B]
test_simple_benchmark[engine_BladeLLM-False-zmq-True-False-/mnt/model/Qwen2.5-7B]
test_simple_benchmark[engine_BladeLLM-False-zmq-True-True-/mnt/model/Qwen2.5-7B]
|
test_simple_benchmark[engine_vLLM-False-zmq-False-False-/mnt/model/Qwen2.5-7B]
test_simple_benchmark[engine_vLLM-False-rayqueue-False-False-/mnt/model/Qwen2.5-7B]
|
test_request_trace[rayqueue-engine_BladeLLM-/mnt/model/Qwen2.5-7B]
test_request_trace[zmq-engine_BladeLLM-/mnt/model/Qwen2.5-7B]
|
test_request_trace[rayqueue-engine_vLLM-/mnt/model/Qwen2.5-7B]
test_request_trace[zmq-engine_vLLM-/mnt/model/Qwen2.5-7B]
|
test_simple_benchmark[engine_vLLM-False-zmq-False-False-/mnt/model/Qwen2.5-7B]
test_simple_benchmark[engine_vLLM-False-rayqueue-False-False-/mnt/model/Qwen2.5-7B]
|
test_request_trace[rayqueue-engine_vLLM-/mnt/model/Qwen2.5-7B]
test_request_trace[zmq-engine_vLLM-/mnt/model/Qwen2.5-7B]
|
test_simple_benchmark[engine_vLLM-False-zmq-False-False-/mnt/model/Qwen2.5-7B]
test_simple_benchmark[engine_vLLM-False-rayqueue-False-False-/mnt/model/Qwen2.5-7B]
|
test_simple_benchmark[engine_BladeLLM-False-zmq-False-False-/mnt/model/Qwen2.5-7B]
test_simple_benchmark[engine_BladeLLM-True-zmq-False-False-/mnt/model/Qwen2.5-7B]
test_simple_benchmark[engine_BladeLLM-False-rayqueue-False-False-/mnt/model/Qwen2.5-7B]
test_simple_benchmark[engine_BladeLLM-False-zmq-True-False-/mnt/model/Qwen2.5-7B]
test_simple_benchmark[engine_BladeLLM-False-zmq-True-True-/mnt/model/Qwen2.5-7B]
|
test_request_trace[rayqueue-engine_BladeLLM-/mnt/model/Qwen2.5-7B]
test_request_trace[zmq-engine_BladeLLM-/mnt/model/Qwen2.5-7B]
|
…ger heartbeat loop
3899158
to
73c6ee3
Compare
test_simple_benchmark[engine_vLLM-False-zmq-False-False-/mnt/model/Qwen2.5-7B]
test_simple_benchmark[engine_vLLM-False-rayqueue-False-False-/mnt/model/Qwen2.5-7B]
|
test_request_trace[rayqueue-engine_vLLM-/mnt/model/Qwen2.5-7B]
test_request_trace[zmq-engine_vLLM-/mnt/model/Qwen2.5-7B]
|
test_request_trace[rayqueue-engine_BladeLLM-/mnt/model/Qwen2.5-7B]
test_request_trace[zmq-engine_BladeLLM-/mnt/model/Qwen2.5-7B]
|
test_simple_benchmark[engine_BladeLLM-False-zmq-False-False-/mnt/model/Qwen2.5-7B]
test_simple_benchmark[engine_BladeLLM-True-zmq-False-False-/mnt/model/Qwen2.5-7B]
test_simple_benchmark[engine_BladeLLM-False-rayqueue-False-False-/mnt/model/Qwen2.5-7B]
test_simple_benchmark[engine_BladeLLM-False-zmq-True-False-/mnt/model/Qwen2.5-7B]
test_simple_benchmark[engine_BladeLLM-False-zmq-True-True-/mnt/model/Qwen2.5-7B]
|
failover migration P0 ok
FAILOVER_MIGRATING not necessary ok
maybe concurrency migration
timeout for failover migration
random.choice -> rr