Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore <p> tags in table rows #354

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Ignore <p> tags in table rows #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
855c1a0
Ignore <p> tags in table rows
gpanders Apr 19, 2021
7fcb2cf
Merge branch 'master' into no-p-in-table
Alir3z4 May 5, 2021
cf27923
Merge branch 'master' into no-p-in-table
Alir3z4 Nov 10, 2022
2a423af
Merge branch 'master' into no-p-in-table
Alir3z4 Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ChangeLog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ UNRELEASED
* Fix extra line breaks inside html link text (between '[' and ']')
* Fix #344: indent ``<ul>`` inside ``<ol>`` three spaces instead of two to comply with CommonMark, GFM, etc.
* Fix #324: unnecessary spaces around ``<b>``, ``<em>``, and ``strike`` tags.
* Don't wrap tables by default and add a ``--wrap-tables`` config option.
* Feature #198: Ignore ``<p>`` tags inside table rows.
* Don't wrap tables by default and add a ``--wrap-tables`` config option
* Remove support for Python ≤ 3.5. Now requires Python 3.6+.
* Support for Python 3.10.
Expand Down
2 changes: 2 additions & 0 deletions html2text/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,8 @@ def handle_tag(
self.soft_br()
elif self.astack:
pass
elif self.split_next_td:
pass
else:
self.p()

Expand Down
12 changes: 12 additions & 0 deletions test/no_p_in_table.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<!DOCTYPE html> <html>
<head lang="en"> <meta charset="UTF-8"> <title></title> </head>
<body> <h1>This is a test document</h1> With some text, <code>code</code>, <b>bolds</b> and <i>italics</i>. <h2>This is second header</h2> <p style="display: none">Displaynone text</p>
<table>
<tr> <th>Header 1</th> <th>Header 2</th> <th>Header 3</th> </tr>
<tr> <td><p>Content 1</p></td> <td><p>2</p></td> <td><img src="http://lorempixel.com/200/200" alt="200"/> Image!</td> </tr>
<tr> <td><p>Content 1 longer</p></td> <td><p>Content 2</p></td> <td><p>blah</p></td> </tr>
<tr> <td><p>Content </p></td> <td><p>Content 2</p></td> <td><p>blah</p></td> </tr>
<tr> <td><p>t </p></td> <td><p>Content 2</p></td> <td><p>blah blah blah</p></td> </tr>
</table>

</body> </html>
15 changes: 15 additions & 0 deletions test/no_p_in_table.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# This is a test document

With some text, `code`, **bolds** and _italics_.

## This is second header

Displaynone text

Header 1 | Header 2 | Header 3
---|---|---
Content 1 | 2 | ![200](http://lorempixel.com/200/200) Image!
Content 1 longer | Content 2 | blah
Content | Content 2 | blah
t | Content 2 | blah blah blah

Loading