Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support exclusive eni in shared eni #682

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Sep 9, 2024

No description provided.

@l1b0k l1b0k requested a review from BSWANG September 9, 2024 09:12
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 55.23013% with 107 lines in your changes missing coverage. Please review.

Project coverage is 30.32%. Comparing base (ed121a8) to head (b6733c9).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
cmd/terway-cli/node.go 18.05% 56 Missing and 3 partials ⚠️
pkg/controller/node/node.go 82.19% 7 Missing and 6 partials ⚠️
pkg/controller/webhook/mutating.go 50.00% 10 Missing ⚠️
pkg/utils/nodecap/node_capabilities.go 69.69% 9 Missing and 1 partial ⚠️
pkg/controller/multi-ip/node/pool.go 0.00% 4 Missing ⚠️
daemon/server.go 0.00% 3 Missing ⚠️
pkg/eni/node_reconcile.go 0.00% 3 Missing ⚠️
cmd/terway-cli/cni_linux.go 0.00% 2 Missing ⚠️
daemon/builder.go 0.00% 2 Missing ⚠️
cmd/terway-cli/cni.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
+ Coverage   29.25%   30.32%   +1.07%     
==========================================
  Files          79       80       +1     
  Lines        8584     8781     +197     
==========================================
+ Hits         2511     2663     +152     
- Misses       5734     5764      +30     
- Partials      339      354      +15     
Flag Coverage Δ
unittests 30.32% <55.23%> (+1.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@l1b0k l1b0k force-pushed the feat/exclusive_eni branch 5 times, most recently from 7a0c6d4 to 32deaed Compare September 10, 2024 03:47
user can now use node label (k8s.aliyun.com/exclusive-mode-eni-type=eniOnly) to specific the node eni type. The behave is like prev the ENIOnly configed on dameon.

Signed-off-by: l1b0k <[email protected]>
@BSWANG BSWANG merged commit ed64799 into AliyunContainerService:main Sep 10, 2024
9 checks passed
@l1b0k l1b0k deleted the feat/exclusive_eni branch September 10, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants