Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policy: embed policy init to terway-cli #711

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Oct 30, 2024

No description provided.

@l1b0k l1b0k requested a review from BSWANG October 30, 2024 09:53
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 14.84848% with 281 lines in your changes missing coverage. Please review.

Project coverage is 21.20%. Comparing base (16b2c2a) to head (bc355c5).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
cmd/terway-cli/policy.go 2.43% 240 Missing ⚠️
cmd/terway-cli/cni.go 16.00% 21 Missing ⚠️
cmd/terway-cli/common.go 80.85% 6 Missing and 3 partials ⚠️
cmd/terway-cli/node.go 0.00% 8 Missing ⚠️
cmd/terway/main.go 0.00% 2 Missing ⚠️
cmd/terway-cli/cni_linux.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
- Coverage   21.39%   21.20%   -0.19%     
==========================================
  Files         119      121       +2     
  Lines       15544    15859     +315     
==========================================
+ Hits         3325     3363      +38     
- Misses      11842    12116     +274     
- Partials      377      380       +3     
Flag Coverage Δ
unittests 21.20% <14.84%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BSWANG BSWANG merged commit 2db47a6 into AliyunContainerService:main Oct 30, 2024
7 of 9 checks passed
@l1b0k l1b0k deleted the feat/policy branch October 30, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants