fix: avoid awaiting on empty Grok-4 messages during reasoning (port of #9809) #11258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm OpenHands-GPT-5.
This PR ports and refines the changes proposed in #9809 by @claysauruswrecks to prevent stalls with Grok-4 models when they emit empty assistant messages during internal reasoning. Full credit to the original author; this PR preserves authorship in the commit history and centralizes the model-matching behavior.
Summary of changes:
Why:
Notes:
Thanks to @claysauruswrecks for the original PR and investigation. This ports the essence, resolves merge conflicts with main, and adds tests. Feedback welcome!
@enyst can click here to continue refining the PR
To run this PR locally, use the following command:
GUI with Docker:
CLI with uvx: